Date: Tue, 1 Dec 2015 08:37:28 +0100
From: Andreas Herrmann <aherrmann@suse.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org,
        linux-block@vger.kernel.org
Subject: Re: [RFC] blk-mq and I/O scheduling
Message-ID: <20151201073728.GA12319@suselix.suse.de>
References: <20151119120235.GA7966@suselix.suse.de>
 <20151124081932.GA30083@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20151124081932.GA30083@lst.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 782
Lines: 26

On Tue, Nov 24, 2015 at 09:19:32AM +0100, Christoph Hellwig wrote:
> Hi Andreas,

Hi Christoph,

> I don't understand the time slicing algorithm to well, but from the
> blk-mq integration perspective this looks nice, and anything that
> helps improving blk-mq for spinning rust is useful.

I'll put description/comments in the next patch version that hopefully
explain it.

> As a nitpick some of the larger "if (use_time_slice)" blocks should
> be moved into separate helper functions‥

And I'll address this also.


Thanks,

Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/