Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755519AbbLAIqI (ORCPT ); Tue, 1 Dec 2015 03:46:08 -0500 Received: from mail-ob0-f169.google.com ([209.85.214.169]:35269 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751849AbbLAIqF (ORCPT ); Tue, 1 Dec 2015 03:46:05 -0500 MIME-Version: 1.0 In-Reply-To: <20151130163129.9f29d40b969862d3fdbd8c20@linux-foundation.org> References: <1448622860-9689-1-git-send-email-riku.voipio@linaro.org> <20151127200710.GB17820@x> <20151130163129.9f29d40b969862d3fdbd8c20@linux-foundation.org> Date: Tue, 1 Dec 2015 09:46:04 +0100 X-Google-Sender-Auth: EDfcSTQXxQrnILUSQvKrtNCC7Is Message-ID: Subject: Re: [PATCH v2] uselib: default depending if libc5 was used From: Geert Uytterhoeven To: Andrew Morton Cc: Josh Triplett , Riku Voipio , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2660 Lines: 67 Hi Andrew, On Tue, Dec 1, 2015 at 1:31 AM, Andrew Morton wrote: > On Fri, 27 Nov 2015 12:07:10 -0800 Josh Triplett wrote: >> On Fri, Nov 27, 2015 at 01:14:20PM +0200, Riku Voipio wrote: >> > uselib hasn't been used since libc5; glibc does not use it. >> > Deprecate uselib a bit more, by making the default y only >> > if libc5 was widely used on the plaform. >> > >> > This makes arm64 kernel built with defconfig slighly smaller >> > >> > bloat-o-meter: >> > add/remove: 0/3 grow/shrink: 0/2 up/down: 0/-1390 (-1390) >> > function old new delta >> > kernel_config_data 18164 18162 -2 >> > uselib_flags 20 - -20 >> > padzero 216 192 -24 >> > sys_uselib 380 - -380 >> > load_elf_library 964 - -964 >> >> One question below. >> >> > v2: Disable on X86_64 if no 32bit support >> > init/Kconfig | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/init/Kconfig b/init/Kconfig >> > index c24b6f7..a4bc657 100644 >> > --- a/init/Kconfig >> > +++ b/init/Kconfig >> > @@ -285,7 +285,7 @@ config FHANDLE >> > >> > config USELIB >> > bool "uselib syscall" >> > - default y >> > + def_bool ALPHA || M68K || SPARC || X86_32 || (X86_64 && IA32_EMULATION) >> >> IA32_EMULATION depends on X86_64, so doesn't that reduce to: >> def_bool ALPHA || M68K || SPARC || X86_32 || IA32_EMULATION > > It's a bit old fashioned to add an expression like this at the > definition site anyway. The cool new thing is to do > > def_bool ARCH_WANT_USELIB > > then go off and define ARCH_WANT_USELIB in the appropriate places in > the per-arch Kconfig files. That's useful for new to-be-implemented features, but this dependency list is (hopefully) cast in stone. No new architecture should need this. So I see no reason to clutter up more Kconfig files. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/