Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755598AbbLAI53 (ORCPT ); Tue, 1 Dec 2015 03:57:29 -0500 Received: from mail-ob0-f171.google.com ([209.85.214.171]:34726 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754010AbbLAI52 (ORCPT ); Tue, 1 Dec 2015 03:57:28 -0500 MIME-Version: 1.0 In-Reply-To: <20151123175450.GA16041@sophia> References: <20151123175450.GA16041@sophia> Date: Tue, 1 Dec 2015 09:57:27 +0100 Message-ID: Subject: Re: [PATCH] gpio: Add GPIO support for the ACCES 104-IDI-48 From: Linus Walleij To: William Breathitt Gray Cc: Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1182 Lines: 28 On Mon, Nov 23, 2015 at 6:54 PM, William Breathitt Gray wrote: > The ACCES 104-IDI-48 family of PC/104 utility boards feature 48 > individually optically isolated digital inputs. Enabled inputs feature > change-of-state detection capability; if change-of-state detection is > enabled, an interrupt is fired off if a change of input level > (low-to-high or high-to-low) is detected. Change-of-state IRQs are > enabled/disabled on 8-bit boundaries, for a total of six boundaries. > > This driver provides GPIO and IRQ support for these 48 channels of > digital input. The base port address for the device may be configured > via the idi_48_base module parameter. The interrupt line number for the > device may be configured via the idi_48_irq module parameter. > > Signed-off-by: William Breathitt Gray This is a very nice and clean written driver. Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/