Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755691AbbLAI7q (ORCPT ); Tue, 1 Dec 2015 03:59:46 -0500 Received: from down.free-electrons.com ([37.187.137.238]:60846 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754539AbbLAI7n (ORCPT ); Tue, 1 Dec 2015 03:59:43 -0500 Date: Tue, 1 Dec 2015 09:59:40 +0100 From: Maxime Ripard To: Vishnu Patekar Cc: "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , Kumar Gala , "linux@arm.linux.org.uk" , Emilio Lopez , Linus Walleij , Jens Kuske , Hans de Goede , Chen-Yu Tsai , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-sunxi@googlegroups.com" , linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi Message-ID: <20151201085940.GC29263@lukather> References: <1445557577-27383-1-git-send-email-vishnupatekar0510@gmail.com> <1445557577-27383-3-git-send-email-vishnupatekar0510@gmail.com> <20151025202012.GT10947@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nmemrqcdn5VTmUEE" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5594 Lines: 141 --nmemrqcdn5VTmUEE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! On Mon, Nov 30, 2015 at 02:09:14AM +0800, Vishnu Patekar wrote: > >> + reg =3D <0x01c20800 0x400>; > >> + clocks =3D <&osc24M>; > >> + gpio-controller; > >> + interrupt-controller; > >> + #interrupt-cells =3D <3>; > >> + #gpio-cells =3D <3>; > >> + > >> + i2c0_pins_a: i2c0@0 { > >> + allwinner,pins =3D "PH0", "PH1"; > >> + allwinner,function =3D "i2c0"; > >> + allwinner,drive =3D ; > >> + allwinner,pull =3D ; > >> + }; > >> + > >> + i2c1_pins_a: i2c1@0 { > >> + allwinner,pins =3D "PH2", "PH3"; > >> + allwinner,function =3D "i2c1"; > >> + allwinner,drive =3D ; > >> + allwinner,pull =3D ; > >> + }; > >> + > >> + i2c2_pins_a: i2c2@0 { > >> + allwinner,pins =3D "PH4", "PH5"; > >> + allwinner,function =3D "i2c2"; > >> + allwinner,drive =3D ; > >> + allwinner,pull =3D ; > >> + }; > >> + > >> + mmc0_pins_a: mmc0@0 { > >> + allwinner,pins =3D "PF0", "PF1", "PF2", > >> + "PF3", "PF4", "PF5"; > >> + allwinner,function =3D "mmc0"; > >> + allwinner,drive =3D ; > >> + allwinner,pull =3D ; > >> + }; > >> + > >> + mmc1_pins_a: mmc1@0 { > >> + allwinner,pins =3D "PG0", "PG1", "PG2", > >> + "PG3", "PG4", "PG5"; > >> + allwinner,function =3D "mmc1"; > >> + allwinner,drive =3D ; > >> + allwinner,pull =3D ; > >> + }; > >> + > >> + mmc2_8bit_pins: mmc2_8bit { > >> + allwinner,pins =3D "PC5", "PC6", "PC8", > >> + "PC9", "PC10", "PC11", > >> + "PC12", "PC13", "PC14", > >> + "PC15"; > >> + allwinner,function =3D "mmc2"; > >> + allwinner,drive =3D ; > >> + allwinner,pull =3D ; > >> + }; > >> + > >> + uart0_pins_a: uart0@0 { > >> + allwinner,pins =3D "PF2", "PF4"; > >> + allwinner,function =3D "uart0"; > >> + allwinner,drive =3D ; > >> + allwinner,pull =3D ; > >> + }; > >> + > >> + uart0_pins_b: uart0@1 { > >> + allwinner,pins =3D "PB9", "PB10"; > >> + allwinner,function =3D "uart0"; > >> + allwinner,drive =3D ; > >> + allwinner,pull =3D ; > >> + }; > > > > Are you going to use all these options? > > Not, only uart0_pins_a and uart0_pins_b and mmc0_pins_a will be used for = now. > As, these are not enabled, I don't see any harm in keeping those here. It bloats the DT for no particular reason. > Let me know in case you want to remove, I'll do it. Yes, please. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --nmemrqcdn5VTmUEE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWXWF8AAoJEBx+YmzsjxAgOUoP/ikx5StYI1Zu1I4Q8eRMjc9h VVC1ayByc/qadUHbkp4ZZm0z20L5aktXTvTv1hGTUjDW+tqcHupx6axhEd2lDZs0 3fakZUy8Mc8PbrhbOC7RGqZJ4FF6TYNOCddLd2qFZjM9+G4TV2N15S6Ob1xnL+Wo 0luOcZFsFZ0KldNRwOoHM/+ZKppAhafejuWccMMvjEmMABpLgFNdTD77Ah1mmSQ0 lJcykLL7Ctrh3Ip5gb1wFQCOmr9Z4WMiGQH+wKmvSPw6KYrvz/k0nnoI/vPvUfs2 NHfcG8ucHyzxbpHGdkpLVbjzorixRKPUmJ9lkLJj4HtZ49D4CH9vgaiCSrxdYqo9 BG5wgeeYPjf7at2JuXDmoXtdLFDiIlC8Xbzd/iJ/9mubsEUPFUcL+/vJ0xwtRiA5 DxEiQuFR6Ix+okOy1FjJYsrzHNvywW8KR5OLOV7X0mWakkteM1z03FuDhP1sxkRz Yf7/7qDXus6IT/QZFbQiHbaZ/bPAVHmuFs08xav3dehBoFlQApnrAx079m5oezzS 5HHTLI8CKOkkBYWpV9UgyCVd+aTYHbH8hEI4gM9Zet0Y1AAokJRhcYqpP/luAwHc DH4WRAnr6jc0kaSdEuofvvz0/rlZws30uh6SktXlb9MYUlgK6XK56DIkNXPf7pXL r5y/nCUQTmqe1jEdCM+o =18xP -----END PGP SIGNATURE----- --nmemrqcdn5VTmUEE-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/