Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755814AbbLAJBd (ORCPT ); Tue, 1 Dec 2015 04:01:33 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:38404 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754010AbbLAJBb (ORCPT ); Tue, 1 Dec 2015 04:01:31 -0500 Date: Tue, 1 Dec 2015 10:01:27 +0100 From: Daniel Vetter To: Mark yao Cc: Daniel Stone , Linux Kernel Mailing List , dri-devel , linux-rockchip , "linux-arm-kernel@lists.infradead.org" Subject: Re: [RFC PATCH 2/9] drm/rockchip: Use new vblank api drm_crtc_vblank_* Message-ID: <20151201090127.GN17050@phenom.ffwll.local> Mail-Followup-To: Mark yao , Daniel Stone , Linux Kernel Mailing List , dri-devel , linux-rockchip , "linux-arm-kernel@lists.infradead.org" References: <1448940391-23333-1-git-send-email-mark.yao@rock-chips.com> <1448940391-23333-3-git-send-email-mark.yao@rock-chips.com> <565D5B57.4040102@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <565D5B57.4040102@rock-chips.com> X-Operating-System: Linux phenom 4.1.0-2-amd64 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1394 Lines: 49 On Tue, Dec 01, 2015 at 04:33:27PM +0800, Mark yao wrote: > On 2015年12月01日 15:56, Daniel Stone wrote: > >Hi, > > > >On 1 December 2015 at 03:26, Mark Yao wrote: > >>No functional update, drm_vblank_* is the legacy version of > >>drm_crtc_vblank_*. and use new api make driver more clean. > >> > >>Signed-off-by: Mark Yao > >Heh, I had the same patch in my series to fix pageflip events. > > > >Reviewed-by: Daniel Stone > > > >Cheers, > >Daniel > > > > > > > > Hi Daniel > I had picked your patch "[PATCH 1/2] drm/rockchip: Use CRTC vblank event > interface" into my drm-next, this patch is base on it. That really should be mentioned in the commit message, and you must keep the signed-off-by chain intact when adapting or reusing other peoples work. -Daniel > > Thanks for your review. > > -- > Ｍark Yao > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/