Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755743AbbLAJKK (ORCPT <rfc822;w@1wt.eu>);
	Tue, 1 Dec 2015 04:10:10 -0500
Received: from mail-pa0-f47.google.com ([209.85.220.47]:36157 "EHLO
	mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754799AbbLAJKE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 1 Dec 2015 04:10:04 -0500
Date: Tue, 1 Dec 2015 18:11:04 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Kyeongdon Kim <kyeongdon.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH v3 2/2] zram: try vmalloc() after kmalloc()
Message-ID: <20151201091104.GA483@swordfish>
References: <1448597449-17579-1-git-send-email-sergey.senozhatsky@gmail.com>
 <20151201051652.GA894@swordfish>
 <565D3FCD.3060503@lge.com>
 <20151201071542.GB894@swordfish>
 <20151201081620.GA27574@bbox>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151201081620.GA27574@bbox>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1460
Lines: 43

On (12/01/15 17:16), Minchan Kim wrote:
> On Tue, Dec 01, 2015 at 04:15:42PM +0900, Sergey Senozhatsky wrote:
> > On (12/01/15 15:35), Kyeongdon Kim wrote:
> > [..]
> > > @test #4
> > >  kmalloc(f)
> > > __vmalloc(f)
> > > // cannot find failure both until now
> > > 
> > > log message (test #4) :
> > > <4>[  641.440468][7] KDKIM: zcomp_lz4_create: 24: ret = ffffffc002190000
> > > <snip>
> > > <4>[  922.182980][7] KDKIM: zcomp_lz4_create: 24: ret = ffffffc002208000
> > > <snip>
> > > <4>[  923.197593][7] KDKIM: zcomp_lz4_create: 24: ret = ffffffc002020000
> > > <snip>
> > > <4>[  939.813499][7] KDKIM: zcomp_lz4_create: 24: ret = ffffffc0020a0000
> > 
> > Thanks!
> > 
> > > So,is there another problem if we remove the flag from both sides?
> > > 
> > 
> > Technically, '~__GFP_NOMEMALLOC' is what we've been doing for some time (well,
> > always); and, as Minchan noted, zsmalloc does not depend on emergency pools.
> > 
> > I vote for removal of __GFP_NOMEMALLOC from both kmalloc() and __vmalloc().
> > 
> > (user can make ->max_strm big enough to deplete emergency mem; but I tend to
> > ignore it).
> > 
> > Minchan?
> 
> Agree. Do you mind resending patches? :)

OK, will do later today. Thanks.

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/