Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755967AbbLAJnO (ORCPT ); Tue, 1 Dec 2015 04:43:14 -0500 Received: from tundra.namei.org ([65.99.196.166]:37336 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755523AbbLAJnL (ORCPT ); Tue, 1 Dec 2015 04:43:11 -0500 Date: Tue, 1 Dec 2015 20:42:46 +1100 (AEDT) From: James Morris To: Andreas Gruenbacher cc: Alexander Viro , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 04/10] vfs: Distinguish between full xattr names and proper prefixes In-Reply-To: <1448919823-27103-5-git-send-email-agruenba@redhat.com> Message-ID: References: <1448919823-27103-1-git-send-email-agruenba@redhat.com> <1448919823-27103-5-git-send-email-agruenba@redhat.com> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 878 Lines: 28 On Mon, 30 Nov 2015, Andreas Gruenbacher wrote: > Add an additional "name" field to struct xattr_handler. When the name > is set, the handler matches attributes with exactly that name. When the > prefix is set instead, the handler matches attributes with the given > prefix and with a non-empty suffix. > > This patch should avoid bugs like the one fixed in commit c361016a in > the future. > > Signed-off-by: Andreas Gruenbacher Is it worth making an inline wrapper for 'handler->prefix ?: handler->name' ? Reviewed-by: James Morris -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/