Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755979AbbLAJnk (ORCPT ); Tue, 1 Dec 2015 04:43:40 -0500 Received: from regular1.263xmail.com ([211.150.99.137]:48434 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755677AbbLAJnh (ORCPT ); Tue, 1 Dec 2015 04:43:37 -0500 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <565D6BBC.20608@rock-chips.com> Date: Tue, 01 Dec 2015 17:43:24 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Daniel Stone , Linux Kernel Mailing List , dri-devel , linux-rockchip , "linux-arm-kernel@lists.infradead.org" Subject: Re: [RFC PATCH 2/9] drm/rockchip: Use new vblank api drm_crtc_vblank_* References: <1448940391-23333-1-git-send-email-mark.yao@rock-chips.com> <1448940391-23333-3-git-send-email-mark.yao@rock-chips.com> <565D5B57.4040102@rock-chips.com> <20151201090127.GN17050@phenom.ffwll.local> In-Reply-To: <20151201090127.GN17050@phenom.ffwll.local> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1690 Lines: 51 On 2015年12月01日 17:01, Daniel Vetter wrote: > On Tue, Dec 01, 2015 at 04:33:27PM +0800, Mark yao wrote: >> On 2015年12月01日 15:56, Daniel Stone wrote: >>> Hi, >>> >>> On 1 December 2015 at 03:26, Mark Yao wrote: >>>> No functional update, drm_vblank_* is the legacy version of >>>> drm_crtc_vblank_*. and use new api make driver more clean. >>>> >>>> Signed-off-by: Mark Yao >>> Heh, I had the same patch in my series to fix pageflip events. >>> >>> Reviewed-by: Daniel Stone >>> >>> Cheers, >>> Daniel >>> >>> >>> >> Hi Daniel >> I had picked your patch "[PATCH 1/2] drm/rockchip: Use CRTC vblank event >> interface" into my drm-next, this patch is base on it. > That really should be mentioned in the commit message, and you must keep > the signed-off-by chain intact when adapting or reusing other peoples > work. > -Daniel Oh, Sorry for that, this patch is another patch rebase on Daniel Stone's one, I use "base on it" may be ambiguity. like that: 0e6919f drm/rockchip: Use new vblank api drm_crtc_vblank_* 4f0cb7c drm/rockchip: Use CRTC vblank event interface Thanks for pointing that, I will be carefully next time. >> Thanks for your review. >> >> -- >> Ｍark Yao >> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/dri-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/