Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755883AbbLAJxz (ORCPT ); Tue, 1 Dec 2015 04:53:55 -0500 Received: from tundra.namei.org ([65.99.196.166]:37358 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755651AbbLAJxx (ORCPT ); Tue, 1 Dec 2015 04:53:53 -0500 Date: Tue, 1 Dec 2015 20:53:07 +1100 (AEDT) From: James Morris To: Andreas Gruenbacher cc: Alexander Viro , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 10/10] xattr handlers: Simplify list operation In-Reply-To: <1448919823-27103-11-git-send-email-agruenba@redhat.com> Message-ID: References: <1448919823-27103-1-git-send-email-agruenba@redhat.com> <1448919823-27103-11-git-send-email-agruenba@redhat.com> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 670 Lines: 24 On Mon, 30 Nov 2015, Andreas Gruenbacher wrote: > diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c > index 906022d..61dd93f 100644 > --- a/fs/ocfs2/xattr.c > +++ b/fs/ocfs2/xattr.c > @@ -895,6 +895,8 @@ static int ocfs2_xattr_list_entry(char *buffer, size_t size, > > *result += total_len; > > + /* FIXME: Not checking the ->list operation here ... */ > + What does this mean? -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/