Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755816AbbLAKvL (ORCPT ); Tue, 1 Dec 2015 05:51:11 -0500 Received: from eusmtp01.atmel.com ([212.144.249.242]:58691 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754384AbbLAKvJ (ORCPT ); Tue, 1 Dec 2015 05:51:09 -0500 Subject: Re: [PATCH] ARM: at91: fix pinctrl driver selection To: Ludovic Desroches , References: <1448966680-30281-1-git-send-email-ludovic.desroches@atmel.com> CC: , , , From: Nicolas Ferre Organization: atmel Message-ID: <565D7BAF.6070208@atmel.com> Date: Tue, 1 Dec 2015 11:51:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1448966680-30281-1-git-send-email-ludovic.desroches@atmel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2488 Lines: 84 Le 01/12/2015 11:44, Ludovic Desroches a ?crit : > Move the selection of the pinctrl driver to SoC family level since we > have two pinctrl drivers. It is useless to select one which is not > compatible with the SoC. > > Signed-off-by: Ludovic Desroches Yep, it's even better. I plan to send it to 4.4-fixes very soon. Acked-by: Nicolas Ferre > --- > > This patch is an improvement of this one (already acked by Linus and Nicolas): > https://lkml.org/lkml/2015/9/16/522 > > Without it, at91 pio4 driver is not compiled causing boot failure for SAMA5D2. > > arch/arm/mach-at91/Kconfig | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig > index 9267300..28656c2 100644 > --- a/arch/arm/mach-at91/Kconfig > +++ b/arch/arm/mach-at91/Kconfig > @@ -4,7 +4,6 @@ menuconfig ARCH_AT91 > select ARCH_REQUIRE_GPIOLIB > select COMMON_CLK_AT91 > select PINCTRL > - select PINCTRL_AT91 > select SOC_BUS > > if ARCH_AT91 > @@ -17,6 +16,7 @@ config SOC_SAMA5D2 > select HAVE_AT91_USB_CLK > select HAVE_AT91_H32MX > select HAVE_AT91_GENERATED_CLK > + select PINCTRL_AT91PIO4 > help > Select this if ou are using one of Atmel's SAMA5D2 family SoC. > > @@ -27,6 +27,7 @@ config SOC_SAMA5D3 > select HAVE_AT91_UTMI > select HAVE_AT91_SMD > select HAVE_AT91_USB_CLK > + select PINCTRL_AT91 > help > Select this if you are using one of Atmel's SAMA5D3 family SoC. > This support covers SAMA5D31, SAMA5D33, SAMA5D34, SAMA5D35, SAMA5D36. > @@ -40,6 +41,7 @@ config SOC_SAMA5D4 > select HAVE_AT91_SMD > select HAVE_AT91_USB_CLK > select HAVE_AT91_H32MX > + select PINCTRL_AT91 > help > Select this if you are using one of Atmel's SAMA5D4 family SoC. > > @@ -50,6 +52,7 @@ config SOC_AT91RM9200 > select CPU_ARM920T > select HAVE_AT91_USB_CLK > select MIGHT_HAVE_PCI > + select PINCTRL_AT91 > select SOC_SAM_V4_V5 > select SRAM if PM > help > @@ -65,6 +68,7 @@ config SOC_AT91SAM9 > select HAVE_AT91_UTMI > select HAVE_FB_ATMEL > select MEMORY > + select PINCTRL_AT91 > select SOC_SAM_V4_V5 > select SRAM if PM > help > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/