Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753678AbbLALBU (ORCPT ); Tue, 1 Dec 2015 06:01:20 -0500 Received: from mx2.suse.de ([195.135.220.15]:50495 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbbLALBS (ORCPT ); Tue, 1 Dec 2015 06:01:18 -0500 From: Andreas Schwab To: Arnd Bergmann Cc: Yury Norov , linux-arm-kernel@lists.infradead.org, pinskia@gmail.com, Prasun.Kapoor@caviumnetworks.com, catalin.marinas@arm.com, Nathan_Lynch@mentor.com, linux-kernel@vger.kernel.org, agraf@suse.de, klimov.linux@gmail.com, broonie@kernel.org, jan.dakinevich@gmail.com, joseph@codesourcery.com, ddaney.cavm@gmail.com, bamvor.zhangjian@huawei.com, philipp.tomsich@theobroma-systems.com, andrey.konovalov@linaro.org, christoph.muellner@theobroma-systems.com Subject: Re: [PATCH v6 14/19] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it References: <1447795019-30176-1-git-send-email-ynorov@caviumnetworks.com> <20151130202141.GA23254@yury-N73SV> <87bnaafrt0.fsf@igel.home> <2776283.xtmDQm6BqS@wuerfel> X-Yow: You were s'posed to laugh! Date: Tue, 01 Dec 2015 12:01:12 +0100 In-Reply-To: <2776283.xtmDQm6BqS@wuerfel> (Arnd Bergmann's message of "Tue, 01 Dec 2015 11:22:02 +0100") Message-ID: <87zixue8lj.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1270 Lines: 33 Arnd Bergmann writes: > On Tuesday 01 December 2015 10:20:59 Andreas Schwab wrote: >> Yury Norov writes: >> >> > There's a tricky bug with signal stack, that Andreas also discovered. >> >> That was only a confusion about the compat state of sys_rt_sigaction. >> It just requires making sure glibc uses the correct (64bit layout) >> struct kernel_sigaction. > > I don't think we need to use the 64-bit version of sigaction, both > kernel and libc are simpler if we use the normal 32-bit version. Since glibc has to do the conversion anyway (due to sigset_t), using the 64bit layout avoids a second conversion in the kernel. > We should always default to using the generic 32-bit structures > unless there is a strong reason not to. The goal should be to avoid conversion layers where it makes sense. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/