Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756150AbbLAMQ4 (ORCPT ); Tue, 1 Dec 2015 07:16:56 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35667 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755185AbbLAMQx (ORCPT ); Tue, 1 Dec 2015 07:16:53 -0500 X-Sasl-enc: mGHsP+wYQP5BGS7ou4shc3mp0B6LWbxZWhMPaeFkn7ti 1448972212 Date: Tue, 1 Dec 2015 12:16:51 +0000 From: Graeme Gregory To: "Rafael J. Wysocki" Cc: Graeme Gregory , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, shannon.zhao@linaro.org, Len Brown , Russell King Subject: Re: [PATCH 2/3] ACPI: scan add call to probe amba devices Message-ID: <20151201121627.GA4036@xora-haswell.xora.org.uk> References: <1443609530-21524-1-git-send-email-graeme.gregory@linaro.org> <1443609530-21524-3-git-send-email-graeme.gregory@linaro.org> <8504062.kEYB5C4QA7@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8504062.kEYB5C4QA7@vostro.rjw.lan> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1614 Lines: 42 On Tue, Dec 01, 2015 at 03:16:53AM +0100, Rafael J. Wysocki wrote: > On Wednesday, September 30, 2015 11:38:49 AM Graeme Gregory wrote: > > Call the amba device creation function in the default enumeration path, > > this is the same location platform devices are probed. > > First, I'm sorry for the glacially slow response here. > > > Cc: Rafael J. Wysocki > > Cc: Len Brown > > Cc: Russell King > > Signed-off-by: Graeme Gregory > > --- > > drivers/acpi/scan.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > > index f834b8c..aa3184e 100644 > > --- a/drivers/acpi/scan.c > > +++ b/drivers/acpi/scan.c > > @@ -1633,8 +1633,10 @@ static void acpi_default_enumeration(struct acpi_device *device) > > acpi_dev_get_resources(device, &resource_list, acpi_check_spi_i2c_slave, > > &is_spi_i2c_slave); > > acpi_dev_free_resource_list(&resource_list); > > - if (!is_spi_i2c_slave) > > + if (!is_spi_i2c_slave) { > > + acpi_create_amba_device(device); > > Do you really have to add this here? > > It would be much cleaner to use a new scan handler instead. > I can certainly look into doing that, I cannot from a quick scan see any reason not too. I just didn't think of it. Graeme -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/