Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756326AbbLANSA (ORCPT <rfc822;w@1wt.eu>);
	Tue, 1 Dec 2015 08:18:00 -0500
Received: from mail-lf0-f50.google.com ([209.85.215.50]:34240 "EHLO
	mail-lf0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755043AbbLANR7 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 1 Dec 2015 08:17:59 -0500
Subject: Re: [PATCH 1/6] net: thunderx: Force to load octeon-mdio before bgx
 driver.
To: Sunil Goutham <sunil.kovvuri@gmail.com>, netdev@vger.kernel.org
References: <y> <1448961223-41888-2-git-send-email-sunil.kovvuri@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Sunil.Goutham@caviumnetworks.com,
        Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>,
        Sunil Goutham <sgoutham@cavium.com>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <565D9E04.8010203@cogentembedded.com>
Date: Tue, 1 Dec 2015 16:17:56 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <1448961223-41888-2-git-send-email-sunil.kovvuri@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1245
Lines: 35

Hello.

On 12/1/2015 12:13 PM, Sunil Goutham wrote:

> From: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
>
> Signed-off-by: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
> Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
> ---
>   drivers/net/ethernet/cavium/thunder/thunder_bgx.c |    3 +++
>   drivers/net/ethernet/cavium/thunder/thunder_bgx.h |    1 +
>   2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> index 180aa9f..1fb72dd 100644
> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> @@ -1009,6 +1009,9 @@ static int bgx_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   	struct bgx *bgx = NULL;
>   	u8 lmac;
>
> +	/*Load octeon mdio driver*/

    Please insert spaces after /* and before */ (unless it's a common comment 
style in this driver).

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/