Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755299AbbLAPMJ (ORCPT ); Tue, 1 Dec 2015 10:12:09 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:40326 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751915AbbLAPMI (ORCPT ); Tue, 1 Dec 2015 10:12:08 -0500 From: Felipe Balbi To: Mathias Nyman , CC: , , Subject: Re: [TESTPATCH v2] xhci: fix usb2 resume timing and races. In-Reply-To: <565DB7FF.2040903@linux.intel.com> References: <1448958418-6114-1-git-send-email-mathias.nyman@linux.intel.com> <87d1uq1bpz.fsf@saruman.tx.rr.com> <565DB7FF.2040903@linux.intel.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 1 Dec 2015 09:11:58 -0600 Message-ID: <871tb619vl.fsf@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2428 Lines: 74 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Mathias Nyman writes: > On 01.12.2015 16:32, Felipe Balbi wrote: >> >> Hi, >> >> Mathias Nyman writes: >>> usb2 ports need to signal resume for 20ms before moving to U0 state. >> >> at least 20ms ;-) Recently, we decided to drive resume for 40ms to >> support devices with broken FW. >> > > True, but specs talk about 20ms, and I'm just trying to give some context= for what's > going on. This testpatch doesn't touch the timings. > > Daniel is able to trigger a USB2 xhci resume issue which I hope is fixed = with this patch. > This is especially made for his setup running a 4.3 kernel > > If this works I'll clean up all the "20ms" in the commit message and comm= ents. > > Just noticed that xhci USB2 host initiated resume uses a hardcoded msleep= (20). > That needs to be changed to USB_RESUME_TIMEOUT at some point. > For now I'm just interested in knowing if this patch works. > >> >> this 'v2' note doesn't have to go into commit log, IMO. >> > > It's going to be cleaned out as well, just there to explain to Daniel, an= d the world why > a second version of the testpatch was created. all right, thanks ;-) =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWXbi/AAoJEIaOsuA1yqRE71UQAKcVmlqq85sDPowb87vI7h73 7/Rrs4XrFqV8zuFMYBnUyHDSe/lstrVQqBJ2dVzv2uJmYHUt+DKdpGV7NLBNFB4j 1R8CzoJnHJYps9aVkVaxnvrCNpoDKF/0N3GVQccsRyUUt8KjRi+Xlu7geicUjPBc 0oAPebyoo9bD63wh/uB7cq6JsLS2LhMVmb/x8BBIDiucluOzMJf/W8jFIVf67RJc Rg9Xtcx4h5/cHpS0b7XfaMzkvsyx2x5IGkyNbqETgXbSNuY2Lt7tbAoWk5iGw31F azikavJTc/TnqtOJdatbpjTQGoGyMtdkbSMed5ljuiQxDtD9RFWkyoehas7/PpX0 ryRkerztQkQtDNTg9HQTra2/qDkrBVCU6tsQldq7gZpCSIOvhnxIic+wc8sklPw9 Fi7pN9HTiOevKP3UBvcCcxzusJpKvC6NY3S3cbODbU9NA36pPT9m9f9i0UByYtJA fjQBa9PWL4hXNEI3S/O6lM+t5vGEtahXKs+YLclOYiyYc/mLC3rR5uVzviRCLCXU OmPR3K/xXC5XHdKLj7iwW+HgVwuc7jGB+LDiSjHEYdOLouRdk6niInUb2f1Az79Q Ucjq2kogTIafxZtGkvG1J1uuUMkNWAJEImWdY6GbdNDjpye2tsyOX6JpmqhR5HVe pXXTPLjAmx4+PRgk3ioZ =NexO -----END PGP SIGNATURE----- --=-=-=-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/