Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752929AbbLAP1F (ORCPT ); Tue, 1 Dec 2015 10:27:05 -0500 Received: from mail-yk0-f182.google.com ([209.85.160.182]:36457 "EHLO mail-yk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbbLAP1C (ORCPT ); Tue, 1 Dec 2015 10:27:02 -0500 MIME-Version: 1.0 In-Reply-To: <1448976866-7892-3-git-send-email-m.szyprowski@samsung.com> References: <1448976866-7892-1-git-send-email-m.szyprowski@samsung.com> <1448976866-7892-3-git-send-email-m.szyprowski@samsung.com> Date: Tue, 1 Dec 2015 16:27:02 +0100 Message-ID: Subject: Re: [PATCH v3 2/3] ARM: amba: Move reading of periphid to amba_match() From: Ulf Hansson To: Marek Szyprowski Cc: linux-samsung-soc , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Russell King - ARM Linux , Tomeu Vizoso , Greg Kroah-Hartman , Kukjin Kim , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2581 Lines: 69 On 1 December 2015 at 14:34, Marek Szyprowski wrote: > From: Tomeu Vizoso > > Reading the periphid when the Primecell device is registered means that > the apb pclk must be available by then or the device won't be registered > at all. > > By reading the periphid in amba_match() we can return -EPROBE_DEFER if > the apb pclk isn't there yet and the device will be retried later. > > Signed-off-by: Tomeu Vizoso > [minor code adjustments, added missing comment] > Signed-off-by: Marek Szyprowski > --- > drivers/amba/bus.c | 77 +++++++++++++++++++++++++++++------------------------- > 1 file changed, 41 insertions(+), 36 deletions(-) > > diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c > index f009936..879a421 100644 > --- a/drivers/amba/bus.c > +++ b/drivers/amba/bus.c > @@ -24,6 +24,8 @@ > > #define to_amba_driver(d) container_of(d, struct amba_driver, drv) > > +static int amba_read_periphid(struct amba_device *dev); > + > static const struct amba_id * > amba_lookup(const struct amba_id *table, struct amba_device *dev) > { > @@ -43,11 +45,23 @@ static int amba_match(struct device *dev, struct device_driver *drv) > { > struct amba_device *pcdev = to_amba_device(dev); > struct amba_driver *pcdrv = to_amba_driver(drv); > + int ret; > > /* When driver_override is set, only bind to the matching driver */ > if (pcdev->driver_override) > return !strcmp(pcdev->driver_override, drv->name); > > + /* Do plug-n-play if no hard-coded primecell ID has been provided */ > + if (!pcdev->periphid) { > + ret = amba_read_periphid(pcdev); > + if (ret) { > + if (ret != -EPROBE_DEFER) > + dev_err(dev, "Failed to read periphid: %d", > + ret); If you anyway are printing errors in the driver core, why do it here as well? I guess you need to make a call, either here or in driver core. I am fine with whatever way, just not both. > + return ret; > + } > + } > + Besides the minor comment above, you may add my: Reviewed-by: Ulf Hansson Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/