Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755501AbbLAQLh (ORCPT ); Tue, 1 Dec 2015 11:11:37 -0500 Received: from mail-oi0-f42.google.com ([209.85.218.42]:36458 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755172AbbLAQLe (ORCPT ); Tue, 1 Dec 2015 11:11:34 -0500 MIME-Version: 1.0 In-Reply-To: <20151201121512.40ce9cce@bbrezillon> References: <1446742735-20824-1-git-send-email-punnaia@xilinx.com> <20151120193342.GX64635@google.com> <20151201121512.40ce9cce@bbrezillon> Date: Tue, 1 Dec 2015 21:41:33 +0530 X-Google-Sender-Auth: iXoJZkVp0i7kC4xj5YGRL9f6gHs Message-ID: Subject: Re: [PATCH] mtd: Expand the ecc placement locations to 1216 From: punnaiah choudary kalluri To: Boris Brezillon Cc: Brian Norris , Punnaiah Choudary Kalluri , David Woodhouse , "michals@xilinx.com" , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-api@vger.kernel.org, Punnaiah Choudary Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1519 Lines: 45 Hi Boris, On Tue, Dec 1, 2015 at 4:45 PM, Boris Brezillon wrote: > Brian, Punnaiah, > > On Fri, 20 Nov 2015 11:33:42 -0800 > Brian Norris wrote: > >> On Thu, Nov 05, 2015 at 10:28:55PM +0530, Punnaiah Choudary Kalluri wrote: >> > Device like MT29F32G08ABCDBJ4 have a writesize/oobsize of 16K/1216 Bytes. >> > So, increasing the maximum ecc placement locations to 1216 >> >> I'd really prefer not increasing the size of the internal arrays any >> more. The structures should be rewritten to be dynamic. > > I already started this migration (you can find the code here [1]). I > was planning to rework this series to make the eccpos definition mimic > what's done for oobfree (as suggested by Brian) before sending it, but > I'm not sure when I'll be able to do that, so if you really need that > quickly I suggest you submit those patches instead of reimplementing > it yourself. > Sure. let me check your implementation and then send these patches for review with your sign off. Thanks, Punnaiah > Best Regards, > > Boris > > [1]https://github.com/bbrezillon/linux-sunxi/commits/nand/ecclayout > > -- > Boris Brezillon, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/