Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755276AbbLAQXL (ORCPT ); Tue, 1 Dec 2015 11:23:11 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:43488 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753877AbbLAQXJ (ORCPT ); Tue, 1 Dec 2015 11:23:09 -0500 X-Originating-IP: 50.39.163.18 Date: Tue, 1 Dec 2015 08:23:01 -0800 From: Josh Triplett To: Riku Voipio Cc: Geert Uytterhoeven , Andrew Morton , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] uselib: default depending if libc5 was used Message-ID: <20151201162300.GA26089@x> References: <1448622860-9689-1-git-send-email-riku.voipio@linaro.org> <20151127200710.GB17820@x> <20151130163129.9f29d40b969862d3fdbd8c20@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1536 Lines: 32 On Tue, Dec 01, 2015 at 02:35:24PM +0200, Riku Voipio wrote: > On 1 December 2015 at 10:46, Geert Uytterhoeven wrote: > > On Tue, Dec 1, 2015 at 1:31 AM, Andrew Morton wrote: > >> On Fri, 27 Nov 2015 12:07:10 -0800 Josh Triplett wrote: > >>> IA32_EMULATION depends on X86_64, so doesn't that reduce to: > >>> def_bool ALPHA || M68K || SPARC || X86_32 || IA32_EMULATION > > Ok. looks cleaner to me. > > >> It's a bit old fashioned to add an expression like this at the > >> definition site anyway. The cool new thing is to do > >> > >> def_bool ARCH_WANT_USELIB > >> > >> then go off and define ARCH_WANT_USELIB in the appropriate places in > >> the per-arch Kconfig files. > > > > That's useful for new to-be-implemented features, but this dependency list is > > (hopefully) cast in stone. No new architecture should need this. > > So I see no reason to clutter up more Kconfig files. > > I agree. Splitting oneline patch to a patch that changes 5 files around kernel > tree only risks merge conflicts in this case. True; I take back what I said about that approach being cleaner. It does ease maintenance in cases where the list may change, but in this case, the list should never change again. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/