Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756391AbbLAQ1B (ORCPT ); Tue, 1 Dec 2015 11:27:01 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36423 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755963AbbLAQY6 (ORCPT ); Tue, 1 Dec 2015 11:24:58 -0500 MIME-Version: 1.0 In-Reply-To: <565D9E04.8010203@cogentembedded.com> References: <1448961223-41888-2-git-send-email-sunil.kovvuri@gmail.com> <565D9E04.8010203@cogentembedded.com> Date: Tue, 1 Dec 2015 21:54:57 +0530 Message-ID: Subject: Re: [PATCH 1/6] net: thunderx: Force to load octeon-mdio before bgx driver. From: Sunil Kovvuri To: Sergei Shtylyov Cc: Linux Netdev List , LKML , LAKML , Sunil Goutham , Thanneeru Srinivasulu , Sunil Goutham Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1441 Lines: 42 Thanks a lot, will fix and repost the patch. On Tue, Dec 1, 2015 at 6:47 PM, Sergei Shtylyov wrote: > Hello. > > On 12/1/2015 12:13 PM, Sunil Goutham wrote: > >> From: Thanneeru Srinivasulu >> >> Signed-off-by: Thanneeru Srinivasulu >> Signed-off-by: Sunil Goutham >> --- >> drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 3 +++ >> drivers/net/ethernet/cavium/thunder/thunder_bgx.h | 1 + >> 2 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c >> b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c >> index 180aa9f..1fb72dd 100644 >> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c >> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c >> @@ -1009,6 +1009,9 @@ static int bgx_probe(struct pci_dev *pdev, const >> struct pci_device_id *ent) >> struct bgx *bgx = NULL; >> u8 lmac; >> >> + /*Load octeon mdio driver*/ > > > Please insert spaces after /* and before */ (unless it's a common comment > style in this driver). > > [...] > > MBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/