Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756524AbbLARTI (ORCPT ); Tue, 1 Dec 2015 12:19:08 -0500 Received: from mail-ig0-f175.google.com ([209.85.213.175]:36123 "EHLO mail-ig0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755546AbbLARTG (ORCPT ); Tue, 1 Dec 2015 12:19:06 -0500 MIME-Version: 1.0 In-Reply-To: <20151201171322.GD4341@pd.tnic> References: <1448404418-28800-1-git-send-email-toshi.kani@hpe.com> <1448404418-28800-2-git-send-email-toshi.kani@hpe.com> <20151201135000.GB4341@pd.tnic> <20151201171322.GD4341@pd.tnic> Date: Tue, 1 Dec 2015 09:19:05 -0800 X-Google-Sender-Auth: FsgJ9Mb7gY7oP2BTipn8iTw5lqs Message-ID: Subject: Re: [PATCH v3 1/3] resource: Add @flags to region_intersects() From: Linus Torvalds To: Borislav Petkov Cc: Dan Williams , Toshi Kani , Andrew Morton , "Rafael J. Wysocki" , Tony Luck , Vishal L Verma , Linux MM , "linux-nvdimm@lists.01.org" , Linux ACPI , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1108 Lines: 28 On Tue, Dec 1, 2015 at 9:13 AM, Borislav Petkov wrote: > > Oh sure, I didn't mean you. I was simply questioning that whole > identify-resource-by-its-name approach. And that came with: > > 67cf13ceed89 ("x86: optimize resource lookups for ioremap") > > I just think it is silly and that we should be identifying resource > things in a more robust way. I could easily imagine just adding a IORESOURCE_RAM flag (or SYSMEM or whatever). That sounds sane. I agree that comparing the string is ugly. > Btw, the ->name thing in struct resource has been there since a *long* > time It's pretty much always been there. It is indeed meant for things like /proc/iomem etc, and as a debug aid when printing conflicts, yadda yadda. Just showing the numbers is usually useless for figuring out exactly *what* something conflicts with. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/