Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756569AbbLAR1H (ORCPT ); Tue, 1 Dec 2015 12:27:07 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:42560 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376AbbLAR1E (ORCPT ); Tue, 1 Dec 2015 12:27:04 -0500 Date: Tue, 1 Dec 2015 10:26:55 -0700 From: Jason Gunthorpe To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Jarkko Sakkinen , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Martin Wilck , Peter Huewe Subject: Re: [PATCH 1/2] tpm_tis: Disable interrupt auto probing on a per-device basis Message-ID: <20151201172655.GA691@obsidianresearch.com> References: <1448911632-20070-1-git-send-email-jgunthorpe@obsidianresearch.com> <1448911632-20070-2-git-send-email-jgunthorpe@obsidianresearch.com> <20151201071743.GP10431@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151201071743.GP10431@pengutronix.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 689 Lines: 18 On Tue, Dec 01, 2015 at 08:17:43AM +0100, Uwe Kleine-K?nig wrote: > Hello Jason, > > On Mon, Nov 30, 2015 at 12:27:11PM -0700, Jason Gunthorpe wrote: > > Instead of clearing the global interrupts flag when any device > > does not have an interrupt just pass -1 through tpm_info.irq. > > Is there a reason not to use 0 for the invalid irq? 0 already means 'no IRQ given, do auto-probe'. -1 is now 'no IRQ given, disable IRQ operation' Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/