Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932076AbbLARjo (ORCPT ); Tue, 1 Dec 2015 12:39:44 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:48118 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756687AbbLARjm (ORCPT ); Tue, 1 Dec 2015 12:39:42 -0500 Date: Tue, 1 Dec 2015 10:39:40 -0700 From: Jason Gunthorpe To: "Wilck, Martin" Cc: Jarkko Sakkinen , "tpmdd-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "'Uwe =?iso-8859-1?Q?Kleine-K=F6nig'?=" Subject: Re: [tpmdd-devel] [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter Message-ID: <20151201173940.GC691@obsidianresearch.com> References: <1448911632-20070-1-git-send-email-jgunthorpe@obsidianresearch.com> <1448911632-20070-3-git-send-email-jgunthorpe@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 965 Lines: 25 On Tue, Dec 01, 2015 at 12:50:28PM +0100, Wilck, Martin wrote: > The patch introduces one user-visible change, because now the ACPI and > PnP drivers are registered even with "force=1". This causes my TPM to be > show up twice in sysfs: Registering all the drivers is deliberate, IMHO, force should not be used if the driver binds normally. However, getting two is a bug, and it is because tpm_tis is not doing resource management. I'll add another patch to fix that.. Also, I'll change the order of the driver registers so that the platform driver goes first, that way if force is used the platform driver will bind and still auto probe irqs and then the other drivers will bounce off the claimed resource. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/