Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756759AbbLASNg (ORCPT ); Tue, 1 Dec 2015 13:13:36 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:34512 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756169AbbLASNf (ORCPT ); Tue, 1 Dec 2015 13:13:35 -0500 Date: Tue, 1 Dec 2015 10:13:26 -0800 From: Joshua Clayton To: Alexandre Belloni Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/9] rtc-pcf2123: Document all registers and useful bits Message-ID: <20151201101326.34c11d79@jclayton-pc> In-Reply-To: <20151124215136.GD3950@piout.net> References: <20151124215136.GD3950@piout.net> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2275 Lines: 62 On Tue, 24 Nov 2015 22:51:36 +0100 Alexandre Belloni wrote: > Hi, > > On 04/11/2015 at 07:36:32 -0800, Joshua Clayton wrote : > > Document all 16 registers in the pcf2123, as well as > > useful bit masks from the Control1 and seconds registers > > > > Signed-off-by: Joshua Clayton > > --- > > drivers/rtc/rtc-pcf2123.c | 23 ++++++++++++++++++++++- > > 1 file changed, 22 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c > > index d1953bb..7756210 100644 > > --- a/drivers/rtc/rtc-pcf2123.c > > +++ b/drivers/rtc/rtc-pcf2123.c > > @@ -47,6 +47,7 @@ > > > > #define DRV_VERSION "0.6" > > > > +/* REGISTERS */ > > #define PCF2123_REG_CTRL1 (0x00) /* Control Register > > 1 */ #define PCF2123_REG_CTRL2 (0x01) /* Control > > Register 2 */ #define PCF2123_REG_SC > > (0x02) /* datetime */ @@ -56,7 +57,27 @@ > > #define PCF2123_REG_DW (0x06) > > #define PCF2123_REG_MO (0x07) > > #define PCF2123_REG_YR (0x08) > > - > > +#define PCF2123_REG_ALRM_MN (0x09) /* Alarm > > Registers */ +#define PCF2123_REG_ALRM_HR (0x0a) > > +#define PCF2123_REG_ALRM_DM (0x0b) > > +#define PCF2123_REG_ALRM_DW (0x0c) > > +#define PCF2123_REG_OFFSET (0x0d) /* Clock Rate > > Offset Register */ +#define PCF2123_REG_TMR_CLKOUT > > (0x0e) /* Timer Registers */ +#define > > PCF2123_REG_CTDWN_TMR (0x0f) +#define > > PCF2123_REG_MAX (PCF2123_REG_CTDWN_TMR) + > > +/* PCF2123_REG_CTRL1 BITS */ > > +#define CTRL1_CLEAR (0x00) /* Clear */ > > +#define CTRL1_CORRECTION_INT (0x02) /* Correction > > Interrupt */ +#define CTRL1_12_HOUR (0x04) /* > > 12 hour time */ +#define CTRL1_STOP (0x20) /* > > Stop the clock */ +#define CTRL1_SW_RESET > > (0x58) /* Software reset */ +#define > > CTRL1_EXT_TEST (0x80) /* External Clock Test > > mode */ + +/* PCF2123_REG_SC BITS */ > > +#define OSC_HAS_STOPPED (0x80) /* Clock has > > been stopped */ + > > Can you use the BIT() macro? > > Sure. I Will change that in v2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/