Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756786AbbLASWJ (ORCPT ); Tue, 1 Dec 2015 13:22:09 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:33782 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756002AbbLASWH (ORCPT ); Tue, 1 Dec 2015 13:22:07 -0500 Date: Tue, 1 Dec 2015 10:22:03 -0800 From: Joshua Clayton To: Alexandre Belloni Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/9] rtc-pcf2123: put the chip reset into a function Message-ID: <20151201102203.64119ba9@jclayton-pc> In-Reply-To: <20151124231736.GF3950@piout.net> References: <20151124231736.GF3950@piout.net> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 906 Lines: 29 On Wed, 25 Nov 2015 00:17:36 +0100 Alexandre Belloni wrote: > On 04/11/2015 at 07:36:36 -0800, Joshua Clayton wrote : > > A commit message, even when simple is mandatory. > Sorry about that. I know better. will fix for v2 > > + /* See if the counter was actually stopped */ > > + dev_dbg(dev, "checking for presence of RTC\n"); > > + ret = pcf2123_read(dev, PCF2123_REG_CTRL1, rxbuf, > > sizeof(rxbuf)); > > + if (ret < 0) > > + return ret; > > + > > + dev_dbg(dev, "received data from RTC (0x%02X 0x%02X)\n", > > + rxbuf[0], rxbuf[1]); > > This is not properly aligned (use checkpatch --strict) > > Will fix. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/