Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756905AbbLAS6l (ORCPT ); Tue, 1 Dec 2015 13:58:41 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:54965 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756874AbbLAS6j (ORCPT ); Tue, 1 Dec 2015 13:58:39 -0500 From: Jason Gunthorpe To: Jarkko Sakkinen , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Cc: Martin Wilck , Peter Huewe , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Subject: [PATCH v2 0/3] tpm_tis: Clean up force module parameter Date: Tue, 1 Dec 2015 11:58:26 -0700 Message-Id: <1448996309-15220-1-git-send-email-jgunthorpe@obsidianresearch.com> X-Mailer: git-send-email 2.1.4 X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1461 Lines: 35 Drive the force=1 flow through the driver core. There are two main reasons to do this: 1) To enable tpm_tis for OF environments requires a platform_device anyhow, so the probe/release code needs to be re-used for that. 2) Recent changes in the core code break the assumption that a driver will be 'attached' to things created through platform_device_register_simple, which causes the tpm core to blow up. v2: - Make sure we request the mem resource in tpm_tis to avoid double-loading the driver - Re-order the init sequence so that a forced platform device gets first crack at loading, and excludes the other mechanisms via the above - Checkpatch clean - Gotos renamed Martin, this should fix the double loading you noticed, please confirm. There is a possibility the force path needs a bit more code to be compatible with devm_ioremap_resource, I'm not sure, hoping not. Jason Gunthorpe (3): tpm_tis: Disable interrupt auto probing on a per-device basis tpm_tis: Use devm_ioremap_resource tpm_tis: Clean up the force=1 module parameter drivers/char/tpm/tpm_tis.c | 203 +++++++++++++++++++++++++++------------------ 1 file changed, 122 insertions(+), 81 deletions(-) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/