Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756833AbbLATKi (ORCPT ); Tue, 1 Dec 2015 14:10:38 -0500 Received: from down.free-electrons.com ([37.187.137.238]:52133 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756016AbbLATKf (ORCPT ); Tue, 1 Dec 2015 14:10:35 -0500 Date: Tue, 1 Dec 2015 20:10:32 +0100 From: Boris Brezillon To: Brian Norris Cc: David Woodhouse , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mtd: nand: fix ONFI parameter page layout Message-ID: <20151201201032.551f5562@bbrezillon> In-Reply-To: <20151201190510.GY64635@google.com> References: <1448274187-22174-1-git-send-email-boris.brezillon@free-electrons.com> <20151130201729.GK64635@google.com> <20151201103318.16a2e46a@bbrezillon> <20151201190510.GY64635@google.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1821 Lines: 52 On Tue, 1 Dec 2015 11:05:10 -0800 Brian Norris wrote: > On Tue, Dec 01, 2015 at 10:33:18AM +0100, Boris Brezillon wrote: > > On Mon, 30 Nov 2015 12:17:29 -0800 > > Brian Norris wrote: > > > On Mon, Nov 23, 2015 at 11:23:07AM +0100, Boris Brezillon wrote: > > > > src_ssync_features field is only 1 byte large, and the 4th reserved area > > > > is actually 8 bytes large. > > > > > > > > Signed-off-by: Boris Brezillon > > > > Fixes d1e1f4e42b5 ("mtd: nand: add support for reading ONFI parameters from NAND device") > > > > Cc: #v2.6.37+ > > > > > > Did you see an actual problem from this? (And is this deserving of > > > stable?) I could imagine an out-of-tree driver might try to use t_ald > > > (which should actually be t_adl, right?) > > > > Yes, should be t_adl, not t_ald. Do you want me to send another patch > > for that, or will you take care of it? > > I'll send a quick patch. > > > > and get the wrong value. But no > > > one does that in-tree yet. > > > > Fair enough, we can just drop the stable and fixes tag. Do you want me > > to resend it? > > I presume this means you didn't see any actual problems caused by this > patch, other than new development referencing it? Yep, I noticed the problem when playing with the driver strength feature. > > Applied without the stable tag. I kept the fixes tag. > > Thanks, > Brian -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/