Date: Tue, 01 Dec 2015 14:30:47 -0500 (EST)
Message-Id: <20151201.143047.82022857078130793.davem@davemloft.net>
To: sunil.kovvuri@gmail.com
Cc: eric.dumazet@gmail.com, p.fedin@samsung.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Sunil.Goutham@caviumnetworks.com, sgoutham@cavium.com
Subject: Re: [PATCH 3/6] net: thunderx: Increase transmit queue length
From: David Miller <davem@davemloft.net>
In-Reply-To: <CA+sq2Ce9oH-kCDO8hK_wX+ZZdXyyBuT4V2bt5Ab+2=pEX+BO+w@mail.gmail.com>
References: <01d101d12c46$2de43b40$89acb1c0$@samsung.com>
	<1448983985.25582.35.camel@edumazet-glaptop2.roam.corp.google.com>
	<CA+sq2Ce9oH-kCDO8hK_wX+ZZdXyyBuT4V2bt5Ab+2=pEX+BO+w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 923
Lines: 21

From: Sunil Kovvuri <sunil.kovvuri@gmail.com>
Date: Tue, 1 Dec 2015 22:00:49 +0530

> Increasing descriptor ring size will lead to more memory allocation.
> And what you are seeing is a memory alloc failure and doesn't seem
> to be due to this driver change.  I mean it looks like the behavior
> will be same for other drivers as well.

The driver should successfully recover from out of memory situations
and not stop RX/TX completely.

There might be some other problem with your driver causing this.

Don't put this off as not "related" to your patch, it is as this
introduces the behavior for this user, and you should fix it before
expecting me to apply this patch series.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/