Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932124AbbLAUSI (ORCPT ); Tue, 1 Dec 2015 15:18:08 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:56548 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755436AbbLAUSF (ORCPT ); Tue, 1 Dec 2015 15:18:05 -0500 Date: Tue, 01 Dec 2015 15:18:02 -0500 (EST) Message-Id: <20151201.151802.2271909049212392672.davem@davemloft.net> To: peter@hurleysoftware.com Cc: gregkh@linuxfoundation.org, jslaby@suse.cz, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, sasha.levin@oracle.com, stable@vger.kernel.org Subject: Re: [PATCH] wan/x25: Fix use-after-free in x25_asy_open_tty() From: David Miller In-Reply-To: <1448651919-4239-1-git-send-email-peter@hurleysoftware.com> References: <1448651919-4239-1-git-send-email-peter@hurleysoftware.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Dec 2015 12:18:05 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 880 Lines: 21 From: Peter Hurley Date: Fri, 27 Nov 2015 14:18:39 -0500 > The N_X25 line discipline may access the previous line discipline's closed > and already-freed private data on open [1]. > > The tty->disc_data field _never_ refers to valid data on entry to the > line discipline's open() method. Rather, the ldisc is expected to > initialize that field for its own use for the lifetime of the instance > (ie. from open() to close() only). ... > Reported-and-tested-by: Sasha Levin > Cc: > Signed-off-by: Peter Hurley Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/