Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756660AbbLAUcr (ORCPT ); Tue, 1 Dec 2015 15:32:47 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:56800 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754356AbbLAUcl (ORCPT ); Tue, 1 Dec 2015 15:32:41 -0500 Date: Tue, 01 Dec 2015 15:32:39 -0500 (EST) Message-Id: <20151201.153239.181267823939116963.davem@davemloft.net> To: razor@blackwall.org Cc: linux-kernel@vger.kernel.org, shm@cumulusnetworks.com, gospo@cumulusnetworks.com, roopa@cumulusnetworks.com, dsa@cumulusnetworks.com, nikolay@cumulusnetworks.com, akinobu.mita@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH] net: add support for netdev notifier error injection From: David Miller In-Reply-To: <1448714728-12729-1-git-send-email-razor@blackwall.org> References: <1448714728-12729-1-git-send-email-razor@blackwall.org> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Dec 2015 12:32:40 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1272 Lines: 29 From: Nikolay Aleksandrov Date: Sat, 28 Nov 2015 13:45:28 +0100 > From: Nikolay Aleksandrov > > This module allows to insert errors in some of netdevice's notifier > events. All network drivers use these notifiers to signal various events > and to check if they are allowed, e.g. PRECHANGEMTU and CHANGEMTU > afterwards. Until recently I had to run failure tests by injecting > a custom module, but now this infrastructure makes it trivial to test > these failure paths. Some of the recent bugs I fixed were found using > this module. > Here's an example: > $ cd /sys/kernel/debug/notifier-error-inject/netdev > $ echo -22 > actions/NETDEV_CHANGEMTU/error > $ ip link set eth0 mtu 1024 > RTNETLINK answers: Invalid argument > > CC: Akinobu Mita > CC: "David S. Miller" > CC: netdev > Signed-off-by: Nikolay Aleksandrov This looks fine, applied to net-next, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/