Date: Tue, 01 Dec 2015 15:35:17 -0500 (EST)
Message-Id: <20151201.153517.224543138214404348.davem@davemloft.net>
To: mhocko@kernel.org
Cc: pavel@ucw.cz, akpm@osdl.org, linux-kernel@vger.kernel.org,
        jcliburn@gmail.com, chris.snook@gmail.com, netdev@vger.kernel.org,
        rjw@rjwysocki.net, linux-mm@kvack.org, nic-devel@qualcomm.com,
        ronangeles@gmail.com, ebiederm@xmission.com
Subject: Re: [PATCH] Improve Atheros ethernet driver not to do order 4
 GFP_ATOMIC allocation
From: David Miller <davem@davemloft.net>
In-Reply-To: <20151130132129.GB21950@dhcp22.suse.cz>
References: <20151127082010.GA2500@dhcp22.suse.cz>
	<20151128145113.GB4135@amd>
	<20151130132129.GB21950@dhcp22.suse.cz>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=utf-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 700
Lines: 18

From: Michal Hocko <mhocko@kernel.org>
Date: Mon, 30 Nov 2015 14:21:29 +0100

> On Sat 28-11-15 15:51:13, Pavel Machek wrote:
>> 
>> atl1c driver is doing order-4 allocation with GFP_ATOMIC
>> priority. That often breaks  networking after resume. Switch to
>> GFP_KERNEL. Still not ideal, but should be significantly better.
> 
> It is not clear why GFP_KERNEL can replace GFP_ATOMIC safely neither
> from the changelog nor from the patch context.

Earlier in the function we do a GFP_KERNEL kmalloc so: 

¯\_(ツ)_/¯

It should be fine.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?