Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756808AbbLAU4J (ORCPT ); Tue, 1 Dec 2015 15:56:09 -0500 Received: from mga01.intel.com ([192.55.52.88]:54826 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755238AbbLAU4G (ORCPT ); Tue, 1 Dec 2015 15:56:06 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,370,1444719600"; d="scan'208";a="5727973" Date: Tue, 1 Dec 2015 12:55:11 -0800 From: David Cohen To: Felipe Balbi Cc: Heikki Krogerus , Chanwoo Choi , Greg Kroah-Hartman , MyungJoo Ham , Lu Baolu , Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] extcon: add driver for Intel USB mux Message-ID: <20151201205511.GB5617@psi-dev26.jf.intel.com> References: <1448976758-35807-1-git-send-email-heikki.krogerus@linux.intel.com> <1448976758-35807-2-git-send-email-heikki.krogerus@linux.intel.com> <87r3j5zz51.fsf@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r3j5zz51.fsf@saruman.tx.rr.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1154 Lines: 41 Hi Felipe, On Tue, Dec 01, 2015 at 02:34:34PM -0600, Felipe Balbi wrote: [snip] > > +EXPORT_SYMBOL_GPL(intel_usb_mux_register); > > + > > +void intel_usb_mux_unregister(struct intel_usb_mux *mux) > > +{ > > + extcon_unregister_notifier(&mux->edev, EXTCON_USB_HOST, &mux->nb); > > + extcon_dev_unregister(&mux->edev); > > + writel(mux->cfg0_ctx, mux->regs + INTEL_MUX_CFG0); > > + iounmap(mux->regs); > > + kfree(mux); > > +} > > +EXPORT_SYMBOL_GPL(intel_usb_mux_unregister); > > so who's gonna call these two functions ? IMO, this looks like a recipe > for randbuild breakage. There are function stubs on header file when the functions aren't available. But also notice CONFIG_EXTCON_INTEL_USB is not user-selectable. It's automatically selected when a driver that requires it is selected too. With the 2 cases above, IMHO it should not bring issues with randbuild tests. Br, David > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/