From: Felipe Balbi <balbi@ti.com>
To: David Cohen <david.a.cohen@linux.intel.com>
CC: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] extcon: add driver for Intel USB mux
In-Reply-To: <20151201205511.GB5617@psi-dev26.jf.intel.com>
References: <1448976758-35807-1-git-send-email-heikki.krogerus@linux.intel.com> <1448976758-35807-2-git-send-email-heikki.krogerus@linux.intel.com> <87r3j5zz51.fsf@saruman.tx.rr.com> <20151201205511.GB5617@psi-dev26.jf.intel.com>
User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu)
Date: Tue, 1 Dec 2015 15:22:11 -0600
Message-ID: <87lh9dzwxo.fsf@saruman.tx.rr.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1;
	protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2372
Lines: 70

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

David Cohen <david.a.cohen@linux.intel.com> writes:
> Hi Felipe,
>
> On Tue, Dec 01, 2015 at 02:34:34PM -0600, Felipe Balbi wrote:
>
> [snip]
>
>> > +EXPORT_SYMBOL_GPL(intel_usb_mux_register);
>> > +
>> > +void intel_usb_mux_unregister(struct intel_usb_mux *mux)
>> > +{
>> > +	extcon_unregister_notifier(&mux->edev, EXTCON_USB_HOST, &mux->nb);
>> > +	extcon_dev_unregister(&mux->edev);
>> > +	writel(mux->cfg0_ctx, mux->regs + INTEL_MUX_CFG0);
>> > +	iounmap(mux->regs);
>> > +	kfree(mux);
>> > +}
>> > +EXPORT_SYMBOL_GPL(intel_usb_mux_unregister);
>>=20
>> so who's gonna call these two functions ? IMO, this looks like a recipe
>> for randbuild breakage.
>
> There are function stubs on header file when the functions aren't
> available.
> But also notice CONFIG_EXTCON_INTEL_USB is not user-selectable. It's
> automatically selected when a driver that requires it is selected too.
>
> With the 2 cases above, IMHO it should not bring issues with randbuild
> tests.

right now it won't break, that's correct :-) But things change over time
and this is, at least, fragile. I mean, why couldn't this mux be an
actual driver ?

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJWXg+EAAoJEIaOsuA1yqRE72AP/R4OdsNTwq4v7OdDaaGhb39v
gzJ3QFaL0FgE/meUKhoxOgNzRKxxLsJ9PuSu5vts7Ypd+y0W2x+MkGzTVQV0f0ac
O2GOrDlbGDRMvlUsHicCxaHAqPpIWZKsIWKVJt/Zkx4FoaX0ELu0r4seWwjW8DI0
iBccQ7LR/m/LLVoH7A8zRdJzCWDQHZ/t5EsBJXCtYJFF5hPCFJB37d++j9JBHhtK
1WqhO/8ljyJJFHrwN0YMWKNNQXdPgJKZ6zGVsHTXjb8KWqd29f4Ke/S4R/VLzhcv
x6EpZQkJgZ/uG9pwjQ4BfpfzgJO5A2w+eQaba0BDroNqO+rR8lzsCgi3pICIeQ+O
R0Ac06aJ0hu87a9bFUhcyFhjTYh91dQcGEa0wqVQd6oEWiVff9pNLi14keUJ0ISF
AzuVhRjN+jKJ9cufnDfkTwNqc6+FxcFkca7FqWJgeX03zcG2ceM3mJxhheJpMTbl
xe9MlAfU28McRfBHP87gxlW4nassRgRlL58WbdrYB/xCEIWTGXuKz4LlB7+5SCh2
6a0x7pf111HbEEXM4EfOLxqtYYtGx8lGdj8Gd7Y9TWrEdjlWmnIHZ0HToEfGvvmv
wri/NEEhW/ifAycqobnMlY/2jFdDvITNYGN4YYMGItXd5zg1Sqs9egPr/fjE8Mf/
rnSxmNJdkwQl6X1Dq92I
=kR1O
-----END PGP SIGNATURE-----
--=-=-=--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/