Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756970AbbLAV2O (ORCPT ); Tue, 1 Dec 2015 16:28:14 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:57704 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754507AbbLAV2M (ORCPT ); Tue, 1 Dec 2015 16:28:12 -0500 Date: Tue, 01 Dec 2015 16:28:10 -0500 (EST) Message-Id: <20151201.162810.1750455760429212300.davem@davemloft.net> To: igal.liberman@freescale.com Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, scottwood@freescale.com, madalin.bucur@freescale.com, pebolle@tiscali.nl, joakim.tjernlund@transmode.se, ppc@mindchasers.com, stephen@networkplumber.org Subject: Re: [v8, 2/6] fsl/fman: Add FMan support From: David Miller In-Reply-To: <1448886062-16962-3-git-send-email-igal.liberman@freescale.com> References: <1448886062-16962-1-git-send-email-igal.liberman@freescale.com> <1448886062-16962-3-git-send-email-igal.liberman@freescale.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Dec 2015 13:28:12 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1483 Lines: 38 From: Date: Mon, 30 Nov 2015 14:20:58 +0200 > +typedef irqreturn_t (fman_exceptions_cb)(struct fman *fman, > + enum fman_exceptions exception); Function and function pointer declarations and definitions should be indented such that the second and subsequent lines begin precisely at the first column after the openning parenthesis of the first line. Please audit this and fix it in your entire submission, almost ever new such case is done incorrectly. > + fman->state->exceptions = (EX_DMA_BUS_ERROR | > + EX_DMA_READ_ECC | > + EX_DMA_SYSTEM_WRITE_ECC | > + EX_DMA_FM_WRITE_ECC | > + EX_FPM_STALL_ON_TASKS | > + EX_FPM_SINGLE_ECC | > + EX_FPM_DOUBLE_ECC | > + EX_QMI_DEQ_FROM_UNKNOWN_PORTID | > + EX_BMI_LIST_RAM_ECC | > + EX_BMI_STORAGE_PROFILE_ECC | > + EX_BMI_STATISTICS_RAM_ECC | > + EX_MURAM_ECC | > + EX_BMI_DISPATCH_RAM_ECC | > + EX_QMI_DOUBLE_ECC | > + EX_QMI_SINGLE_ECC); The same applies to multi-line parenthesized expressions like this one. Again, please audit and fix this in your entire submission. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/