Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932077AbbLAWCO (ORCPT ); Tue, 1 Dec 2015 17:02:14 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:34530 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753506AbbLAWCN (ORCPT ); Tue, 1 Dec 2015 17:02:13 -0500 MIME-Version: 1.0 In-Reply-To: <565E06C6.3080707@gmx.de> References: <20151201164147.18471.52359.stgit@bhelgaas-glaptop2.roam.corp.google.com> <565E06C6.3080707@gmx.de> Date: Tue, 1 Dec 2015 14:02:11 -0800 Message-ID: Subject: Re: [PATCH] parisc: Remove unused pcibios_init_bus() From: Grant Grundler To: Helge Deller Cc: Bjorn Helgaas , "James E.J. Bottomley" , open list , linux-parisc , Grant Grundler Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1314 Lines: 31 On Tue, Dec 1, 2015 at 12:44 PM, Helge Deller wrote: > On 01.12.2015 17:41, Bjorn Helgaas wrote: >> There are no callers of pcibios_init_bus(), so remove it. > > True, pcibios_init_bus() isn't called anywhere, so it should be removed. > > But I wonder if we might need to initialize latency and parity for PCI-PCI > bridges somewhere else then? pcibios_fixup_bus() appears to do that...but I don't know the call chain. I used cscope to look for PCI_BRIDGE_CTL_PARITY. > In one of my machines I have a i960 based RAID controller which isn't working > yet (I think it's internally based on a PCI-PCI bridge), and maybe this > is the reason it doesn't work? I will need to test it (e.g. firmware doesn't > fully initializes PCI-PCI bridges, which is why this code was added once). If lspci doesn't show the PCI-PCI bridge, the i960 RAID card is using that internally. parisc (and any other architecture) should discover and configure all PCI-PCI bridges already. I know it did for the "multifunction" cards I had available 10 years ago. cheers, grant -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/