Date: Tue, 1 Dec 2015 14:35:06 -0800
From: Greg KH <gregkh@linuxfoundation.org>
To: Saurabh Sengar <saurabh.truth@gmail.com>
Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap
Message-ID: <20151201223506.GA27400@kroah.com>
References: <1446812190-8833-1-git-send-email-saurabh.truth@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1446812190-8833-1-git-send-email-saurabh.truth@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1215
Lines: 37

On Fri, Nov 06, 2015 at 05:46:30PM +0530, Saurabh Sengar wrote:
> added iounmap inorder to free memory mapped to base before returning
> 
> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
> ---
>  drivers/usb/host/pci-quirks.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index f940056..332f687 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -990,7 +990,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
>  			/* We're reading garbage from the controller */
>  			dev_warn(&pdev->dev,
>  				 "xHCI controller failing to respond");
> -			return;
> +			goto iounmap;
>  		}
>  
>  		if (!ext_cap_offset)
> @@ -1061,7 +1061,7 @@ hc_init:
>  			 "xHCI HW did not halt within %d usec status = 0x%x\n",
>  			 XHCI_MAX_HALT_USEC, val);
>  	}
> -
> +iounmap:
>  	iounmap(base);
>  }
>  

Does not apply to the tree :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/