Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757421AbbLAXQg (ORCPT ); Tue, 1 Dec 2015 18:16:36 -0500 Received: from smtp-outbound-2.vmware.com ([208.91.2.13]:32970 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757238AbbLAXQe (ORCPT ); Tue, 1 Dec 2015 18:16:34 -0500 From: "Sinclair Yeh" Date: Tue, 1 Dec 2015 15:17:54 -0800 To: Xavier Deguillard Cc: x86@kernel.org, pv-drivers@vmware.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW_PORT macro Message-ID: <20151201231754.GB11239@syeh-linux> References: <1449008047-8252-1-git-send-email-syeh@vmware.com> <1449008332-9394-1-git-send-email-syeh@vmware.com> <1449008332-9394-6-git-send-email-syeh@vmware.com> <20151201223801.GN24642@xdeguillard-ws.eng.vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151201223801.GN24642@xdeguillard-ws.eng.vmware.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1174 Lines: 32 Thanks! Done. On Tue, Dec 01, 2015 at 02:38:01PM -0800, Xavier Deguillard wrote: > Hey Sinclair, > > On Tue, Dec 01, 2015 at 02:18:52PM -0800, Sinclair Yeh wrote: > > +#define VMWARE_BALLOON_CMD(cmd, data, result) \ > > +({ \ > > + unsigned long __status, __dummy1, __dummy2; \ > > + unsigned long __si = 0, __di = 0; \ > > + VMW_PORT(data, VMW_BALLOON_CMD_##cmd, VMW_BALLOON_HV_PORT, \ > > + VMW_BALLOON_HV_MAGIC, \ > > + __status, result, __dummy1, __dummy2, __si, __di);\ > > + if (VMW_BALLOON_CMD_##cmd == VMW_BALLOON_CMD_START) \ > > + result = __dummy1; \ > > + result &= -1UL; \ > > + __status & -1UL; \ > > }) > > You need to indent the '\' with tabs only, and it looks like spaces are > present here (which is also why they don't look aligned). > > Other than that I'm good with this: > > Acked-by: Xavier Deguillard > > Xavier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/