Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932218AbbLAXld (ORCPT ); Tue, 1 Dec 2015 18:41:33 -0500 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:35162 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932183AbbLAXl3 (ORCPT ); Tue, 1 Dec 2015 18:41:29 -0500 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.98.76 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Wed, 2 Dec 2015 08:41:48 +0900 From: Minchan Kim To: "Kirill A. Shutemov" CC: Sasha Levin , Andrew Morton , LKML , "linux-mm@kvack.org" Subject: Re: mm: kernel BUG at mm/huge_memory.c:3272! Message-ID: <20151201234148.GA20632@bbox> References: <565C5F2D.5060003@oracle.com> <20151201212636.GA137439@black.fi.intel.com> MIME-Version: 1.0 In-Reply-To: <20151201212636.GA137439@black.fi.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB06/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2015/12/02 08:41:24, Serialize by Router on LGEKRMHUB06/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2015/12/02 08:41:24, Serialize complete at 2015/12/02 08:41:24 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1986 Lines: 43 On Tue, Dec 01, 2015 at 11:26:36PM +0200, Kirill A. Shutemov wrote: > On Mon, Nov 30, 2015 at 09:37:33AM -0500, Sasha Levin wrote: > > Hi Kirill, > > > > I've hit the following while fuzzing with trinity on the latest -next kernel: > > > > [ 321.348184] page:ffffea0011a20080 count:1 mapcount:1 mapping:ffff8802d745f601 index:0x1802 > > [ 321.350607] flags: 0x320035c00040078(uptodate|dirty|lru|active|swapbacked) > > [ 321.453706] page dumped because: VM_BUG_ON_PAGE(!PageLocked(page)) > > [ 321.455353] page->mem_cgroup:ffff880286620000 > > I think this should help: > > From aadc911f047b094c68b350550556dafabf05af13 Mon Sep 17 00:00:00 2001 > From: "Kirill A. Shutemov" > Date: Fri, 20 Nov 2015 12:20:00 +0200 > Subject: [PATCH] thp: fix split_huge_page vs. deferred_split_scan race > > Minchan[1] and Sasha[2] had reported crash in split_huge_page_to_list() > called from deferred_split_scan() due VM_BUG_ON_PAGE(!PageLocked(page)). > > This can happen because race between deferred_split_scan() and > split_huge_page(). The result of the race is that the page can be split > under deferred_split_scan(). > > The patch prevents this by taking split_queue_lock in > split_huge_page_to_list() when we check if the page can be split. > If the page is suitable for splitting, we remove page from splitting > queue under the same lock, before splitting starts. > > [1] http://lkml.kernel.org/g/20151117073539.GB32578@bbox > [2] http://lkml.kernel.org/g/565C5F2D.5060003@oracle.com > > Signed-off-by: Kirill A. Shutemov > Reported-by: Minchan Kim > Reported-by: Sasha Levin With this, I cannot reprocude the error. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/