Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932277AbbLAXwj (ORCPT ); Tue, 1 Dec 2015 18:52:39 -0500 Received: from mail-ob0-f174.google.com ([209.85.214.174]:33031 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932196AbbLAXwi (ORCPT ); Tue, 1 Dec 2015 18:52:38 -0500 MIME-Version: 1.0 In-Reply-To: <20151201230422.GA11239@syeh-linux> References: <1449008047-8252-1-git-send-email-syeh@vmware.com> <1449008332-9394-1-git-send-email-syeh@vmware.com> <1449008332-9394-4-git-send-email-syeh@vmware.com> <20151201230422.GA11239@syeh-linux> Date: Tue, 1 Dec 2015 15:52:37 -0800 Message-ID: Subject: Re: [PATCH 4/6] Input: Remove vmmouse port reservation From: Dmitry Torokhov To: Sinclair Yeh Cc: X86 ML , "pv-drivers@vmware.com" , "linux-graphics-maintainer@vmware.com" , virtualization@lists.linux-foundation.org, lkml Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1536 Lines: 44 On Tue, Dec 1, 2015 at 3:04 PM, Sinclair Yeh wrote: > Hi, > > On Tue, Dec 01, 2015 at 02:30:05PM -0800, Dmitry Torokhov wrote: >> Hi Sinclair, >> >> On Tue, Dec 1, 2015 at 2:18 PM, Sinclair Yeh wrote: >> > Port reservation is not required. >> >> You need to expand on why we do not need to reserve port. > > Thomas gave me this input earlier, too, so I added the one liner. > > There was a long discussion on accessing the port a few years ago: > https://lkml.org/lkml/2008/9/24/512 > >> >> > Furthermore, this port is shared >> > by other VMware services for host-side communication. >> >> What services would that be? Do they reserve the port? > > This port is used by quite a few guest-to-host communication capabilities, > e.g. getting configuration, logging, etc. Currently multiple kernel > modules, and one or more priviledged guest user mode app, e.g. > open-vmware-tools, use this port without reservation. Ah, I forgot that vmmouse does not have a dedicated port... > > After some internal discussions, it was determined that no reservation > is required when accessing the port in this manner. > > Do you want me to put the above in the commit message? Not about the bit about "internal discussions", but the rest - yes please. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/