Message-ID: <565E41E4.4060606@rock-chips.com>
Date: Wed, 02 Dec 2015 08:57:08 +0800
From: Mark yao <mark.yao@rock-chips.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Luis de Bethencourt <luisbg@osg.samsung.com>, linux-kernel@vger.kernel.org
CC: airlied@linux.ie, heiko@sntech.de, dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, akpm@linux-foundation.org
Subject: Re: [PATCH] drm/rockchip: Fix module autoload for OF platform driver
References: <1448895416-9502-1-git-send-email-luisbg@osg.samsung.com>
In-Reply-To: <1448895416-9502-1-git-send-email-luisbg@osg.samsung.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1795
Lines: 54

On 2015年11月30日 22:56, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>
> Hi,
>
> This is a Resend of a patch from October 20th [0]
>
> I am adding Andrew Morton to the CC list as was recommended at the Korea Linux
> Forum.
>
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
>
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
> A multitude of similar patches have been merged for other drivers, search
> the git log for "module autoload for OF platform driver".
>
> Thanks,
> Luis
>
> [0] https://lkml.org/lkml/2015/10/20/485
>
>   drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index 5d8ae5e..5897851 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -374,6 +374,7 @@ static const struct of_device_id vop_driver_dt_match[] = {
>   	  .data = &rk3288_vop },
>   	{},
>   };
> +MODULE_DEVICE_TABLE(of, vop_driver_dt_match);
>   
>   static inline void vop_writel(struct vop *vop, uint32_t offset, uint32_t v)
>   {
Applied to my drm-fixes, Thanks for this fix.

-- 
Ｍark Yao


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/