Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932329AbbLBBLR (ORCPT ); Tue, 1 Dec 2015 20:11:17 -0500 Received: from mail-vk0-f41.google.com ([209.85.213.41]:34945 "EHLO mail-vk0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757188AbbLBBLO (ORCPT ); Tue, 1 Dec 2015 20:11:14 -0500 MIME-Version: 1.0 In-Reply-To: <878u5dk7si.fsf@gamma.ozlabs.ibm.com> References: <1449013410-19103-1-git-send-email-geyslan@gmail.com> <878u5dk7si.fsf@gamma.ozlabs.ibm.com> Date: Tue, 1 Dec 2015 22:11:13 -0300 Message-ID: Subject: Re: [PATCH] kvm: remove unused variable 'vcpu_book3s' From: "Geyslan G. Bem" To: Daniel Axtens Cc: kvm@vger.kernel.org, Gleb Natapov , LKML , kvm-ppc@vger.kernel.org, Paul Mackerras , Paolo Bonzini , linuxppc-dev@lists.ozlabs.org, Alexander Graf Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1742 Lines: 66 2015-12-01 21:34 GMT-03:00 Daniel Axtens : > "Geyslan G. Bem" writes: > >> The vcpu_book3s struct is assigned but never used. So remove it. > > Just out of interest, how did you find this? Compiler warning? Static > analysis? Manual inspection? Sorry, I should have done the patch self contained. I caught it through static analysis (cppcheck). > > Thanks in advance! You're welcome. > > Regards, > Daniel > >> >> Signed-off-by: Geyslan G. Bem >> --- >> arch/powerpc/kvm/book3s_64_mmu.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/arch/powerpc/kvm/book3s_64_mmu.c b/arch/powerpc/kvm/book3s_64_mmu.c >> index 774a253..9bf7031 100644 >> --- a/arch/powerpc/kvm/book3s_64_mmu.c >> +++ b/arch/powerpc/kvm/book3s_64_mmu.c >> @@ -377,15 +377,12 @@ no_seg_found: >> >> static void kvmppc_mmu_book3s_64_slbmte(struct kvm_vcpu *vcpu, u64 rs, u64 rb) >> { >> - struct kvmppc_vcpu_book3s *vcpu_book3s; >> u64 esid, esid_1t; >> int slb_nr; >> struct kvmppc_slb *slbe; >> >> dprintk("KVM MMU: slbmte(0x%llx, 0x%llx)\n", rs, rb); >> >> - vcpu_book3s = to_book3s(vcpu); >> - >> esid = GET_ESID(rb); >> esid_1t = GET_ESID_1T(rb); >> slb_nr = rb & 0xfff; >> -- >> 2.6.2 >> >> _______________________________________________ >> Linuxppc-dev mailing list >> Linuxppc-dev@lists.ozlabs.org >> https://lists.ozlabs.org/listinfo/linuxppc-dev -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/