Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932335AbbLBCkT (ORCPT ); Tue, 1 Dec 2015 21:40:19 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:45037 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755909AbbLBCkP (ORCPT ); Tue, 1 Dec 2015 21:40:15 -0500 Message-ID: <565E5A00.50803@hisilicon.com> Date: Wed, 2 Dec 2015 10:40:00 +0800 From: Xinwei Kong User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Shawn Guo CC: , , , , , , , , , , , , , , , Subject: Re: [PATCH v2] arm64: dts: add all hi6220 i2c nodes References: <1448524623-10320-1-git-send-email-kong.kongxinwei@hisilicon.com> <20151202020524.GC692@tiger> In-Reply-To: <20151202020524.GC692@tiger> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.119.120] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.565E59F4.00EC,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: ef179b4e42ec0b87c2c14f47000b8579 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2579 Lines: 87 hi Shawn On 2015/12/2 10:05, Shawn Guo wrote: > On Thu, Nov 26, 2015 at 03:57:03PM +0800, Xinwei Kong wrote: >> This patch adds all I2C nodes for the Hi6220 SoC. This hi6220 Soc >> use this I2C IP of Synopsys Designware for HiKey board. >> >> Signed-off-by: Xinwei Kong >> --- >> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 37 +++++++++++++++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> index 82d2488..85d4a8b 100644 >> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> @@ -208,5 +208,42 @@ >> clock-names = "uartclk", "apb_pclk"; >> status = "disabled"; >> }; >> + >> + i2c0: i2c@f7100000 { >> + compatible = "snps,designware-i2c"; >> + reg = <0x0 0xf7100000 0x0 0x1000>; >> + interrupts = <0 44 4>; >> + clocks = <&sys_ctrl HI6220_I2C0_CLK>; >> + clock-names = "clk_i2c0"; > > Neither bindings doc i2c-designware.txt defines this property, nor > kernel i2c-designware driver uses this property. So I think this > clock-names property can just be dropped. > This property should been delete it. I will debug it in HiKey board then send v3 patch. Thank you xinwei > Otherwise, the patch looks good to me. > > Shawn > >> + i2c-sda-hold-time-ns = <300>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>; >> + status = "disabled"; >> + }; >> + >> + i2c1: i2c@f7101000 { >> + compatible = "snps,designware-i2c"; >> + reg = <0x0 0xf7101000 0x0 0x1000>; >> + interrupts = <0 45 4>; >> + clocks = <&sys_ctrl HI6220_I2C1_CLK>; >> + clock-names = "clk_i2c1"; >> + i2c-sda-hold-time-ns = <300>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&i2c1_pmx_func &i2c1_cfg_func>; >> + status = "disabled"; >> + }; >> + >> + i2c2: i2c@f7102000 { >> + compatible = "snps,designware-i2c"; >> + reg = <0x0 0xf7102000 0x0 0x1000>; >> + interrupts = <0 46 4>; >> + clocks = <&sys_ctrl HI6220_I2C2_CLK>; >> + clock-names = "clk_i2c2"; >> + i2c-sda-hold-time-ns = <300>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&i2c2_pmx_func &i2c2_cfg_func>; >> + status = "disabled"; >> + }; >> + >> }; >> }; >> -- >> 1.9.1 >> >> >> > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/