Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757438AbbLBDiJ (ORCPT ); Tue, 1 Dec 2015 22:38:09 -0500 Received: from mail-io0-f180.google.com ([209.85.223.180]:33726 "EHLO mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753742AbbLBDiH (ORCPT ); Tue, 1 Dec 2015 22:38:07 -0500 MIME-Version: 1.0 In-Reply-To: <20151201223506.GA27400@kroah.com> References: <1446812190-8833-1-git-send-email-saurabh.truth@gmail.com> <20151201223506.GA27400@kroah.com> Date: Wed, 2 Dec 2015 09:08:06 +0530 Message-ID: Subject: Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap From: Saurabh Sengar To: Greg KH Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1689 Lines: 44 On 2 December 2015 at 04:05, Greg KH wrote: > On Fri, Nov 06, 2015 at 05:46:30PM +0530, Saurabh Sengar wrote: >> added iounmap inorder to free memory mapped to base before returning >> >> Signed-off-by: Saurabh Sengar >> --- >> drivers/usb/host/pci-quirks.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c >> index f940056..332f687 100644 >> --- a/drivers/usb/host/pci-quirks.c >> +++ b/drivers/usb/host/pci-quirks.c >> @@ -990,7 +990,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev) >> /* We're reading garbage from the controller */ >> dev_warn(&pdev->dev, >> "xHCI controller failing to respond"); >> - return; >> + goto iounmap; >> } >> >> if (!ext_cap_offset) >> @@ -1061,7 +1061,7 @@ hc_init: >> "xHCI HW did not halt within %d usec status = 0x%x\n", >> XHCI_MAX_HALT_USEC, val); >> } >> - >> +iounmap: >> iounmap(base); >> } >> > > Does not apply to the tree :( This patch applies fine on top of "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git". Just now only I have re-verified. Am I expected to send this patch on top of some other git tree/branch ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/