Message-ID: <1449037288.656.23.camel@gmail.com>
Subject: Re: [PATCH] cgroups: move cpuset specific checks from generic code
 to cpuset_can_attach (v2)
From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, linux-kernel@vger.kernel.org,
        Luiz Capitulino <lcapitulino@redhat.com>,
        Chao Peng <chao.p.peng@linux.intel.com>,
        Vikas Shivappa <vikas.shivappa@intel.com>
Date: Wed, 02 Dec 2015 07:21:28 +0100
In-Reply-To: <20151201164916.GE12922@mtj.duckdns.org>
References: <20151125220117.GA990@amt.cnet>
	 <1448539767.7954.214.camel@gmail.com> <20151126223230.GA16962@amt.cnet>
	 <20151201164916.GE12922@mtj.duckdns.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1090
Lines: 27

On Tue, 2015-12-01 at 11:49 -0500, Tejun Heo wrote:
> On Thu, Nov 26, 2015 at 08:32:32PM -0200, Marcelo Tosatti wrote:
> > 
> > Move PF_NO_SETAFFINITY and kthreadd_task checks to cpuset cgroups,  
> > where they belong. This makes it possible to attach PF_NO_SETAFFINITY 
> > tasks to Intel CAT cgroup.
> > 
> > Reported-by: Luiz Capitulino <lcapitulino@redhat.com>
> > Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> > Reviewed-by: Chao Peng <chao.p.peng@linux.intel.com>
> > 
> > v2: "PF_NO_SETAFFINITY check" -> "PF_NO_SETAFFINITY and kthreadd_task
> > checks"
> 
> This wasn't just for cpuset.  It's for all controllers.

Hm, indeed.  Workers landing in a throttled cfs rq wouldn't be as
painful as an rt worker being born in an rq with no rt_runtime, but
could sting.  Workers stuffed into the freezer would sting mightily.

	-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/