Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756764AbbLBHes (ORCPT ); Wed, 2 Dec 2015 02:34:48 -0500 Received: from mail.kernel.org ([198.145.29.136]:47263 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752798AbbLBHeq (ORCPT ); Wed, 2 Dec 2015 02:34:46 -0500 Date: Wed, 2 Dec 2015 15:34:27 +0800 From: Shawn Guo To: Xinwei Kong Cc: robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, pawel.moll@arm.com, galak@codeaurora.org, catalin.marinas@arm.com, w.f@huawei.com, liguozhu@hisilicon.com Subject: Re: [PATCH v3] arm64: dts: add all hi6220 i2c nodes Message-ID: <20151202073427.GM692@tiger> References: <1449037749-14388-1-git-send-email-kong.kongxinwei@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449037749-14388-1-git-send-email-kong.kongxinwei@hisilicon.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2170 Lines: 68 On Wed, Dec 02, 2015 at 02:29:09PM +0800, Xinwei Kong wrote: > This patch adds all I2C nodes for the Hi6220 SoC. This hi6220 Soc > use this I2C IP of Synopsys Designware for HiKey board. > > Signed-off-by: Xinwei Kong > --- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > index 82d2488..6eae673 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > @@ -208,5 +208,36 @@ > clock-names = "uartclk", "apb_pclk"; > status = "disabled"; > }; > + > + i2c0: i2c@f7100000 { > + compatible = "snps,designware-i2c"; > + reg = <0x0 0xf7100000 0x0 0x1000>; > + interrupts = <0 44 4>; > + i2c-sda-hold-time-ns = <300>; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>; > + status = "disabled"; You got me wrong. I was asking you to drop property 'clock-names' only, not 'clocks' together. I do not think it works if you drop property 'clocks', because I see that dw_i2c_plat_probe() will fail if devm_clk_get() fails. Did you test the patch before posting it out? Shawn > + }; > + > + i2c1: i2c@f7101000 { > + compatible = "snps,designware-i2c"; > + reg = <0x0 0xf7101000 0x0 0x1000>; > + interrupts = <0 45 4>; > + i2c-sda-hold-time-ns = <300>; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pmx_func &i2c1_cfg_func>; > + status = "disabled"; > + }; > + > + i2c2: i2c@f7102000 { > + compatible = "snps,designware-i2c"; > + reg = <0x0 0xf7102000 0x0 0x1000>; > + interrupts = <0 46 4>; > + i2c-sda-hold-time-ns = <300>; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c2_pmx_func &i2c2_cfg_func>; > + status = "disabled"; > + }; > + > }; > }; > -- > 1.9.1 > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/