Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757509AbbLBIO2 (ORCPT ); Wed, 2 Dec 2015 03:14:28 -0500 Received: from mga14.intel.com ([192.55.52.115]:7281 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756063AbbLBIO1 (ORCPT ); Wed, 2 Dec 2015 03:14:27 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,372,1444719600"; d="scan'208";a="698594255" Date: Wed, 2 Dec 2015 10:14:23 +0200 From: Jarkko Sakkinen To: Peter Huewe Cc: Jason Gunthorpe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Martin Wilck , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter Message-ID: <20151202081423.GB3458@intel.com> References: <1448996309-15220-1-git-send-email-jgunthorpe@obsidianresearch.com> <20151201213351.GC5071@intel.com> <20151201222223.GA27480@obsidianresearch.com> <7BE9D077-675D-42FE-9461-81317CCA3762@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7BE9D077-675D-42FE-9461-81317CCA3762@gmx.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1355 Lines: 36 On Tue, Dec 01, 2015 at 05:15:14PM -0800, Peter Huewe wrote: > > > Am 1. Dezember 2015 14:22:23 PST, schrieb Jason Gunthorpe : > >On Tue, Dec 01, 2015 at 11:33:51PM +0200, Jarkko Sakkinen wrote: > > > >> I went through the patches and didn't see anything that would shock > >me > >> enough not to apply the patches in the current if they also work when > >> tested *but* are these release critical for Linux v4.4? > >> > >> I got a bit confused about the discussion that was going on about > >"where > >> to fix the probe" crash whether or not both it should be fixed in > >both > >> places. > > > >I'm also confused by that.. > > > >It sounds like force=1 is broken in 4.4 right now - do we care? Should > >we fix this by using Martin's patch? > > I'm not 100% sure if force=1 is broken in 4.3 as well, as I oops when > I have my tpm_crb loaded and then call modprobe tpm_tis force=1 > Peter It'd have to be a different regression because v4.3 does not contain the change that breaks this in v4.4. You had a NUC with discrete TPM module, am I remembering right? /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/