Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932402AbbLBInN (ORCPT ); Wed, 2 Dec 2015 03:43:13 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:36750 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756788AbbLBInL (ORCPT ); Wed, 2 Dec 2015 03:43:11 -0500 Date: Wed, 2 Dec 2015 09:43:10 +0100 From: Valentin Rothberg To: arnd@arndb.de Cc: fengguang.wu@intel.com, arm@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] iio: exynos-adc: fix irqf_oneshot.cocci warnings Message-ID: <20151202084310.GA4665@debian-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1184 Lines: 35 Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci Signed-off-by: Fengguang Wu Signed-off-by: Valentin Rothberg --- The patch looks fine to me: bad things can happen when interrupts are acked before the handler ran. exynos_adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/iio/adc/exynos_adc.c +++ b/drivers/iio/adc/exynos_adc.c @@ -739,7 +739,7 @@ static int exynos_adc_ts_init(struct exy disable_irq(info->tsirq); ret = request_threaded_irq(info->tsirq, NULL, exynos_ts_isr, - 0, "touchscreen", info); + IRQF_ONESHOT, "touchscreen", info); if (ret) input_unregister_device(info->input); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/