Subject: Re: [radeon r100] when ring test fails, provide users with option to
 test
To: =?UTF-8?Q?Michel_D=c3=a4nzer?= <michel@daenzer.net>,
        Pavel Machek <pavel@ucw.cz>
References: <20151128205840.GA26757@amd> <565B56A5.4080702@amd.com>
 <20151129222235.GA25692@amd> <565C0B5A.2040103@amd.com>
 <20151201100110.GE21222@amd> <565E620D.3090605@daenzer.net>
CC: <alexander.deucher@amd.com>, Trivial patch monkey <trivial@kernel.org>,
        <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>
From: =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <565EB26A.9030000@amd.com>
Date: Wed, 2 Dec 2015 09:57:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <565E620D.3090605@daenzer.net>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2015 08:57:27.8276
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0134
X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0343;2:vq0qXsPGr1WLzB6fsRsucdEtvOMnO0hc3ZayyDHF2DMrI1c+FHWEkgE5pLMSTIwnCelt8Qm20iLITst+NzR2aAv0hs8rEaAJGAMcYTPOpGH5If9H4XibeymAFF5ECyFB2vyRbL3tQTIdFPxsCKIVAg==;23:FMULY5veJD0Vsr6AhsdktGMhvhD3ZVW9aA4ehJDYksmdMcJ/vS0Pfpgya1i5LWlJ4FdvWyrabuwZHxQXAptcxBR5UIP17r3JhTjkhoM0kp9+lC7YaBRBxhvSUWN6kv2UO8hYiSZN9SPDZ2FW1GrvWJOpjp/DqQZYKGP24hjvjfAWWkraLdxgI0D63Z+zbosi
X-OriginatorOrg: amd.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2217
Lines: 51

On 02.12.2015 04:14, Michel Dänzer wrote:
> On 01.12.2015 19:01, Pavel Machek wrote:
>> On Mon 2015-11-30 09:39:54, Christian König wrote:
>>> On 29.11.2015 23:22, Pavel Machek wrote:
>>>> On Sun 2015-11-29 20:48:53, Christian König wrote:
>>>>> On 28.11.2015 21:58, Pavel Machek wrote:
>>>>>> Ring test failure is often caused by too high agpmode. Tell the user
>>>>>> what to try.
>>>>>>
>>>>>> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>>>>> NAK, the ring test can fail for any number of reasons and the agpmode is
>>>>> actually rather unlikely to be the cause.
>>>> Well, when I asked on the list "why this is happened" I got "umm,
>>>> noone knows" response that was not exactly helpful. And then someone
>>>> told me about agpmode.
>>>>
>>>> If you know about the reasons it can fail, could you list them near
>>>> the DRM_ERROR, at least as a comment?
>>> Well as I said, that could be any number of reasons. Some of them even
>>> completely unrelated to the driver itself.
>>>
>>> E.g. BIOS setting, faulty hardware, problems with the writeback etc... There
>>> is really not a list you could give here.
>>>
>>> Lowering the agpmode usually helps more to prevent random corruptions and
>>> problems under load.
>> Take a look at
>>
>> http://www.gossamer-threads.com/lists/linux/kernel/2197183
>>
>> . I had a problem, you did not know how to debug it, but it already
>> happened to pebolle at tiscali ... and yes, it was agpmode. That
>> problem is clearly more common then you realize... So this should go
>> in.
> I agree with Christian, but at the very least, agpmode must not be
> mentioned if AGP isn't being used in the first place, i.e. either the
> GPU isn't AGP or is being forced to PCI(e) mode.

Well maybe to explain the background, r100_ring_test() is used for a 
whole bunch of different hardware generations.

Most of them doesn't even have AGP, so mentioning this here would be 
even confusion for the majority of users.

Regards,
Christian.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/