Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757669AbbLBJPY (ORCPT ); Wed, 2 Dec 2015 04:15:24 -0500 Received: from mga02.intel.com ([134.134.136.20]:29487 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756789AbbLBJPT (ORCPT ); Wed, 2 Dec 2015 04:15:19 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,372,1444719600"; d="scan'208";a="611173209" Date: Wed, 2 Dec 2015 11:15:14 +0200 From: Heikki Krogerus To: Lu Baolu Cc: Chanwoo Choi , Greg Kroah-Hartman , MyungJoo Ham , David Cohen , Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] usb: pci-quirks: register USB mux found on Cherrytrail SOC Message-ID: <20151202091514.GB7587@kuha.fi.intel.com> References: <1448976758-35807-1-git-send-email-heikki.krogerus@linux.intel.com> <1448976758-35807-3-git-send-email-heikki.krogerus@linux.intel.com> <565E9785.3000409@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <565E9785.3000409@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1301 Lines: 40 Hi, > > @@ -1029,9 +1030,36 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev) > > writel(val, base + ext_cap_offset + XHCI_LEGACY_CONTROL_OFFSET); > > > > hc_init: > > - if (pdev->vendor == PCI_VENDOR_ID_INTEL) > > + if (pdev->vendor == PCI_VENDOR_ID_INTEL) { > > usb_enable_intel_xhci_ports(pdev); > > > > + /* > > + * Initialize the internal mux that shares a port between USB > > + * Device Controller and xHCI on platforms that have it. > > + */ > > +#define XHCI_INTEL_VENDOR_CAPS 192 > > +#define XHCI_INTEL_USB_MUX_OFFSET 0x80d8 > > + ext_cap_offset = xhci_find_next_cap_offset(base, > > + XHCI_HCC_PARAMS_OFFSET); > > + ext_cap_offset = xhci_find_ext_cap_by_id(base, ext_cap_offset, > > + XHCI_INTEL_VENDOR_CAPS); > > Hi Heikki, > > This helper has been replaced with xhci_find_next_ext_cap() in > commit d5ddcdf(xhci: rework xhci extended capability list parsing functions). > > Need to fix this, otherwise it will not pass compile on top of usb-next. Thanks Baolu. I'll fix it. Cheers, -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/