Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757766AbbLBK1T (ORCPT <rfc822;w@1wt.eu>);
	Wed, 2 Dec 2015 05:27:19 -0500
Received: from mga03.intel.com ([134.134.136.65]:6477 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757755AbbLBK1P (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 2 Dec 2015 05:27:15 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,372,1444719600"; 
   d="scan'208";a="864904003"
Date: Wed, 2 Dec 2015 12:27:10 +0200
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: David Cohen <david.a.cohen@linux.intel.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] extcon: add driver for Intel USB mux
Message-ID: <20151202102710.GC7587@kuha.fi.intel.com>
References: <1448976758-35807-1-git-send-email-heikki.krogerus@linux.intel.com>
 <1448976758-35807-2-git-send-email-heikki.krogerus@linux.intel.com>
 <20151201202834.GA5617@psi-dev26.jf.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151201202834.GA5617@psi-dev26.jf.intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1214
Lines: 39

Hi David,

<snip>

> > +void intel_usb_mux_unregister(struct intel_usb_mux *mux)
> > +{
> 
> There are still 2 pending comments for this unregister function:
> 
> 1) How about a protection against unbalanced unregistering? In case an
> user mistakenly unregisters twice or unregisters without a previous
> registering.

True. You already pointed that out in our off-list thread, but I
forgot. Sorry about that.

> 2) When unregistering, you need to clear the bit CFG0_SW_IDPIN_EN to
> set mux to automatic mode again. Or maybe you could save CFG0's initial
> value and set it again here. Anyway, when unregistering the mux driver
> you need to make sure the mux goes back to its original configuration.

This one is already been taken care of..

> > +	extcon_unregister_notifier(&mux->edev, EXTCON_USB_HOST, &mux->nb);
> > +	extcon_dev_unregister(&mux->edev);
> > +	writel(mux->cfg0_ctx, mux->regs + INTEL_MUX_CFG0);

        ^^^^^^^^^^^^^^^^^^^^


Thanks,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/