Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756382AbbLBK4Y (ORCPT ); Wed, 2 Dec 2015 05:56:24 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:38280 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466AbbLBK4X (ORCPT ); Wed, 2 Dec 2015 05:56:23 -0500 Subject: Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak To: Catalin Marinas References: <564EFF6A.2050709@profitbricks.com> <564F051E.9010703@profitbricks.com> <20151125150806.GG2064@8bytes.org> <5655D072.1000901@profitbricks.com> <565EC9F4.2050401@profitbricks.com> Cc: Joerg Roedel , iommu@lists.linux-foundation.org, Linux Kernel Mailing List From: Michael Wang Message-ID: <565ECE54.5080706@profitbricks.com> Date: Wed, 2 Dec 2015 11:56:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1776 Lines: 53 On 12/02/2015 11:52 AM, Catalin Marinas wrote: [snip] >> >> Is there any more concern? actually we just want to get rid of this >> annoying report on obj won't leak, if you're going to create obj for >> 'irq_lookup_table' that's also fine for us, or will you pick this patch? > > My preference (from a kmemleak perspective) is to tell kmemleak about > the irq_lookup_table. Untested: I'm fine with both solution, will leave the decision to maintainer :-) BTW, could you please send a formal patch with descriptions? Regards, Michael Wang > > diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c > index 013bdfff2d4d..c41609f71cbe 100644 > --- a/drivers/iommu/amd_iommu_init.c > +++ b/drivers/iommu/amd_iommu_init.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1692,6 +1693,7 @@ static struct syscore_ops amd_iommu_syscore_ops = { > > static void __init free_on_init_error(void) > { > + kmemleak_free(irq_lookup_table); > free_pages((unsigned long)irq_lookup_table, > get_order(rlookup_table_size)); > > @@ -1906,6 +1908,7 @@ static int __init early_amd_iommu_init(void) > irq_lookup_table = (void *)__get_free_pages( > GFP_KERNEL | __GFP_ZERO, > get_order(rlookup_table_size)); > + kmemleak_alloc(irq_lookup_table, rlookup_table_size, 1, GFP_KERNEL); > if (!irq_lookup_table) > goto out; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/