Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758008AbbLBLf6 (ORCPT ); Wed, 2 Dec 2015 06:35:58 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:36501 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757960AbbLBLf5 (ORCPT ); Wed, 2 Dec 2015 06:35:57 -0500 Subject: Re: [PATCH] lightnvm: use flags as input parameter To: Wenwei Tao References: <1449055543-3736-1-git-send-email-ww.tao0320@gmail.com> Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <565ED79A.10603@lightnvm.io> Date: Wed, 2 Dec 2015 12:35:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1449055543-3736-1-git-send-email-ww.tao0320@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 31 On 12/02/2015 12:25 PM, Wenwei Tao wrote: > rrpc_get_blk use constant 0 as the input parameter > of nvm_get_blk, this may result in getting gc block > failed unexpectedly. > > Signed-off-by: Wenwei Tao > --- > drivers/lightnvm/rrpc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c > index 75e59c3..d606c7a 100644 > --- a/drivers/lightnvm/rrpc.c > +++ b/drivers/lightnvm/rrpc.c > @@ -182,7 +182,7 @@ static struct rrpc_block *rrpc_get_blk(struct rrpc *rrpc, struct rrpc_lun *rlun, > struct nvm_block *blk; > struct rrpc_block *rblk; > > - blk = nvm_get_blk(rrpc->dev, rlun->parent, 0); > + blk = nvm_get_blk(rrpc->dev, rlun->parent, flags); > if (!blk) > return NULL; > > Thanks Tao, applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/